Dev > Main #9
Merged
Dev > Main #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both Dependency and Metadata are pseudo-folders with the distinct PascalCase, keep it consistent in the targets too.
Should make it easier moving forward for contributors.
This is a must-have for build and analyzer packages which need to pack their dependencies privately, yet they are authored typically in the same solution as the main library they contribute to, and might need its assets as private (i.e. in an analyzer that uses the types in the main library).
When passing --bl, the most common thing to do after the `nugetize` operation finishes is to open the generated log to inspect it. So try to do it automatically by default. Don't fail if we can't open it automatically via the shell operation.
Since we simulate a DTB, turns out that SourceLink turns itself off during those :). So we must explicitly turn it back on to get these values in the output. They can be useful to troubleshoot whether they are being properly calculated.
This optimizes the case where EmitPackage=false, so it's not necessary to create the folder, and also ensures this works if the task is invoked from other targets.
1. When the restore/build operations are taking too long, start outputing the underlying MSBuild messages to help the user troubleshoot/understand what's happening. This is better than just killing the process as we were doing, which can always be done by doing a Ctrl+Break to stop the process. 2. Render unique dependencies and order dependencies for better layout.
This makes it simpler to just place all items of a given type inside a folder, like: ```xml <None Update="@(None)" PackagePath="docs" /> ``` This would place all None items under the `docs` root package dir, preserving the directory structure in the project underneath that folder.
This matches the behavior in SDK pack and makes sense as a default when IsPackable is set, instead of requiring explicit PackageId,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.