Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev > Main #9

Merged
merged 13 commits into from
Oct 4, 2020
Merged

Dev > Main #9

merged 13 commits into from
Oct 4, 2020

Commits on Oct 2, 2020

  1. Configuration menu
    Copy the full SHA
    a8ff4cb View commit details
    Browse the repository at this point in the history
  2. Unify casing of Metadata pseudo PackFolderKind

    Since both Dependency and Metadata are pseudo-folders with the distinct PascalCase, keep it consistent in the targets too.
    kzu committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    e58e2a3 View commit details
    Browse the repository at this point in the history
  3. Apply dotnet-format to whole repo

    Should make it easier moving forward for contributors.
    kzu committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    1ff2401 View commit details
    Browse the repository at this point in the history
  4. Add support for PrivateAssets=all on ProjectReference too

    This is a must-have for build and analyzer packages which need to pack their dependencies privately, yet they are authored typically in the same solution as the main library they contribute to, and might need its assets as private (i.e. in an analyzer that uses the types in the main library).
    kzu committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    292b2c1 View commit details
    Browse the repository at this point in the history
  5. Try to open the structured log viewer by default with --bl

    When passing --bl, the most common thing to do after the `nugetize`
    operation finishes is to open the generated log to inspect it. So
    try to do it automatically by default. Don't fail if we can't open
    it automatically via the shell operation.
    kzu committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    96a93d8 View commit details
    Browse the repository at this point in the history
  6. Enable SourceLink information if available for nugetize

    Since we simulate a DTB, turns out that SourceLink turns itself off during those :). So we must explicitly turn it back on to get these values in the output. They can be useful to troubleshoot whether they are being properly calculated.
    kzu committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    c7d2cbe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5e6642f View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. Move pacakge output path creation to task

    This optimizes the case where EmitPackage=false, so it's not necessary to create the folder, and also ensures this works if the task is invoked from other targets.
    kzu committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    0de6f2a View commit details
    Browse the repository at this point in the history
  2. Improve rendering of nugetize output

    1. When the restore/build operations are taking too long, start outputing the underlying MSBuild messages to help the user troubleshoot/understand what's happening. This is better than just killing the process as we were doing, which can always be done by doing a Ctrl+Break to stop the process.
    
    2. Render unique dependencies and order dependencies for better layout.
    kzu committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    eefde55 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3f59d6 View commit details
    Browse the repository at this point in the history
  4. Add support for PackagePath being just a (base) directory

    This makes it simpler to just place all items of a given type inside a folder, like:
    
    ```xml
    <None Update="@(None)" PackagePath="docs" />
    ```
    
    This would place all None items under the `docs` root package dir, preserving the directory structure in the project underneath that folder.
    kzu committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    4c36bd7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Configuration menu
    Copy the full SHA
    4ed4d90 View commit details
    Browse the repository at this point in the history
  2. When IsPackable=true, default PackageId=AssemblyName

    This matches the behavior in SDK pack and makes sense as a default when IsPackable is set, instead of requiring explicit PackageId,
    kzu committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    3db4b89 View commit details
    Browse the repository at this point in the history