Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider suppressing default success message of single step #343

Closed
hohwille opened this issue May 21, 2024 · 0 comments · Fixed by #413
Closed

Consider suppressing default success message of single step #343

hohwille opened this issue May 21, 2024 · 0 comments · Fixed by #413
Assignees
Labels
CLI IDEasy command-line-interface (parsing args, etc.) enhancement New feature or request step Logging and monitoring of process steps

Comments

@hohwille
Copy link
Member

The VersionCommandlet should print nothing but the version. This allows e.g. in scripts to get the version and determine something on that. If other things are also printed out, then the script will also need some ugly grep hacks to filter out only the version.
We ourselves have stumbled over other tools like docker or wsl where we really had a hard time to just get the version such way without other undesired clutter.

Current we get this:

$ ide --version
SNAPSHOT
Successfully completed ide (--version)

This comes from my step infrastructure in PR #282
In general this is a nice feature but in some cases like this one it is actually undesired.
We should either add the ability for a commandlet to suppress this (might be tricky as this is shomehow produced by the root step that is already created in Ideasy CLI parsing code before we know the actual commandlet) or we simply always suppress the success summary if there is no child step and only success.

@hohwille hohwille added the enhancement New feature or request label May 21, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board May 21, 2024
@hohwille hohwille added CLI IDEasy command-line-interface (parsing args, etc.) step Logging and monitoring of process steps labels May 21, 2024
@hohwille hohwille self-assigned this Jun 25, 2024
@hohwille hohwille added this to the release:2024.06.002 milestone Jun 25, 2024
hohwille added a commit to hohwille/IDEasy that referenced this issue Jun 25, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in IDEasy board Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI IDEasy command-line-interface (parsing args, etc.) enhancement New feature or request step Logging and monitoring of process steps
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant