Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve logging, step debugging, various fixes #282

Merged
merged 28 commits into from
Apr 12, 2024
Merged

improve logging, step debugging, various fixes #282

merged 28 commits into from
Apr 12, 2024

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Apr 9, 2024

Various fixes and enhancements:

  • improve logging infrastructure
  • advanced step debugging with support for hierarchical/nested steps
  • ProcessMode fixes in GitContext
  • fixes and improvements for variables (IdeVariables and EnvironmentVariables)
  • added lots of missing JavaDoc
  • etc. see diff and commits

@hohwille hohwille added git bugfix logging enhancement New feature or request process executing external programs (ProcessContext) documentation Improvements or additions to documentation labels Apr 9, 2024
@hohwille hohwille added this to the release:2024.04.001 milestone Apr 9, 2024
@jan-vcapgemini jan-vcapgemini self-requested a review April 9, 2024 14:19
@coveralls
Copy link
Collaborator

coveralls commented Apr 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8664317503

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 312 unchanged lines in 23 files lost coverage.
  • Overall coverage decreased (-0.08%) to 59.495%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/log/IdeSubLoggerNone.java 1 75.0%
com/devonfw/tools/ide/cli/CliException.java 2 27.27%
com/devonfw/tools/ide/commandlet/EnvironmentCommandlet.java 2 91.49%
com/devonfw/tools/ide/cli/CliAbortException.java 2 0.0%
com/devonfw/tools/ide/variable/AbstractVariableDefinition.java 3 80.85%
com/devonfw/tools/ide/environment/AbstractEnvironmentVariables.java 6 77.84%
com/devonfw/tools/ide/environment/EnvironmentVariables.java 6 82.76%
com/devonfw/tools/ide/commandlet/AbstractUpdateCommandlet.java 8 82.46%
com/devonfw/tools/ide/context/GitContext.java 8 0.0%
com/devonfw/tools/ide/variable/VariableDefinition.java 9 56.41%
Totals Coverage Status
Change from base Build 8618454451: -0.08%
Covered Lines: 4518
Relevant Lines: 7306
💛 - Coveralls

jan-vcapgemini
jan-vcapgemini requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these nice improvements. Looks fine to me. I've added some small CR's and a bugfix.

cli/src/main/java/com/devonfw/tools/ide/cli/CliOfflineException.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/variable/VariableDefinitionStringList.java Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/StepImpl.java Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/Step.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/Step.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/StepSummary.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContextImpl.java Show resolved Hide resolved
hohwille and others added 4 commits April 12, 2024 10:31
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/context/GitContextImpl…
b162534 
….java

Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/step/StepSummary.java
32115c8 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java
0dfbfd3 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille
CliOfflineException.java: complete JavaDoc
7fa7f80
hohwille and others added 3 commits April 12, 2024 10:35
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java
de16143 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/step/Step.java
04062a6 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/step/Step.java
3fc41d5 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@tobka777 tobka777 mentioned this pull request Apr 12, 2024
Closed
jan-vcapgemini
jan-vcapgemini requested changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the reformatter didn't work as intended.

cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/Step.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/Step.java Outdated Show resolved Hide resolved
cli/src/main/java/com/devonfw/tools/ide/step/StepSummary.java Outdated Show resolved Hide resolved
hohwille and others added 5 commits April 12, 2024 17:18
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java
cee0726 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/context/GitContext.java
26005ba 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/step/StepSummary.java
b106714 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/step/Step.java
7887aa9 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille @jan-vcapgemini
Update cli/src/main/java/com/devonfw/tools/ide/step/Step.java
0c1806a 
Co-authored-by: jan-vcapgemini <59438728+jan-vcapgemini@users.noreply.github.com>
@hohwille
Copy link
Member Author

@jan-vcapgemini thanks for your review and improvement suggestions (fixing all my typos).
I now applied all of them and all conversations are now resolved.
I will therefore merge as planned and we again move some steps further...

jan-vcapgemini
jan-vcapgemini approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks ready to merge now.

@hohwille hohwille linked an issue Apr 12, 2024 that may be closed by this pull request
Create ide wrapper script #63
Closed
@hohwille hohwille merged commit 43c1a70 into devonfw:main Apr 12, 2024
4 checks passed
@hohwille hohwille added the story-review marks PRs that will be presented in the sprint-review label May 3, 2024
@hohwille hohwille mentioned this pull request May 3, 2024
Merged
@hohwille
Copy link
Member Author

hohwille commented May 3, 2024

Review together with #295

@hohwille hohwille mentioned this pull request May 21, 2024
Closed
@hohwille hohwille added reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. and removed story-review marks PRs that will be presented in the sprint-review labels Jul 30, 2024
@hohwille hohwille mentioned this pull request Sep 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
bugfix documentation Improvements or additions to documentation enhancement New feature or request git logging process executing external programs (ProcessContext) reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.04.001
Development

Successfully merging this pull request may close these issues.

Create ide wrapper script
3 participants
@hohwille @coveralls @jan-vcapgemini