Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocompletion of 'exit' to shell #533

Closed
jan-vcapgemini opened this issue Aug 13, 2024 · 0 comments · Fixed by #707
Closed

Add autocompletion of 'exit' to shell #533

jan-vcapgemini opened this issue Aug 13, 2024 · 0 comments · Fixed by #707
Assignees
@WorkingAmeise
Labels
enhancement New feature or request
Milestone
release:2024.10.001

Comments

@jan-vcapgemini
Copy link
Contributor

jan-vcapgemini commented Aug 13, 2024 •
edited
Loading

As an IDEasy shell user I want to get the offer to exit the autocompletion mode when I type 'e'.

ATTENTION: For bash completion it does not make sense to suggest exit for completion of e since exit is not a commandlet and ide exit does not make any sense. Hence for the shell specific suggestion this needs to be implemented in a special way.

Hints:

A good start would be to use the AggregateCompleter like this in the ShellCommandlet.java:

Completer completer = new AggregateCompleter(
            new StringsCompleter("exit"), new IdeCompleter((AbstractIdeContext) this.context));

We could also try to use the SystemRegistry as this already has an exit command.
https://github.com/jline/jline3/wiki/Command-Registries#systemregistry
@jan-vcapgemini jan-vcapgemini added the enhancement New feature or request label Aug 13, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Aug 13, 2024
@WorkingAmeise WorkingAmeise self-assigned this Oct 1, 2024
@WorkingAmeise WorkingAmeise moved this from 🆕 New to 🏗 In progress in IDEasy board Oct 1, 2024
@WorkingAmeise WorkingAmeise mentioned this issue Oct 22, 2024
Merged
@hohwille hohwille added this to the release:2024.10.001 milestone Oct 25, 2024
hohwille pushed a commit that referenced this issue Oct 26, 2024
@WorkingAmeise
#533: Add autocompletion of exit in ide shell (#707)
b15bfdf
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Oct 26, 2024
blizzarac added a commit to blizzarac/IDEasy that referenced this issue Oct 27, 2024
@blizzarac
Merge branch 'main' of github.com:blizzarac/IDEasy into alias_bug
5a69d33 
* 'main' of github.com:blizzarac/IDEasy:
  devonfw#533: Add autocompletion of exit in ide shell (devonfw#707)
  Update advanced-tooling-windows.adoc
  simplify FlagProperty usage and allow ToolCommandlets to have long options (devonfw#644)
  Update CHANGELOG.adoc: prepare 2024.10.001
  devonfw#685: update dependencies, added missing deps to LICENSE.adoc, doc rework, jakarta migration (devonfw#686)
  devonfw#689: Added urls to tests (devonfw#695)
@jan-vcapgemini jan-vcapgemini mentioned this issue Nov 4, 2024
Closed
@WorkingAmeise WorkingAmeise mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WorkingAmeise WorkingAmeise

Labels
enhancement New feature or request
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.10.001
Development

Successfully merging a pull request may close this issue.

#533: Add autocompletion of exit in ide shell WorkingAmeise/IDEasy
3 participants
@hohwille @jan-vcapgemini @WorkingAmeise