-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ide-projects to be consisent for tests #689
Labels
enhancement
New feature or request
good first issue
Good for newcomers
refined
Issue in new state was discussed with the team and is clear
test
related to testing and QA
Milestone
Comments
hohwille
added
test
related to testing and QA
good first issue
Good for newcomers
labels
Oct 11, 2024
jan-vcapgemini
added
the
refined
Issue in new state was discussed with the team and is clear
label
Oct 15, 2024
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 15, 2024
Added urls to tests to be consistent
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 15, 2024
Added urls to tests to be consistent
leonrohne27
added a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 15, 2024
Added urls to tests to be consistent
jan-vcapgemini
pushed a commit
that referenced
this issue
Oct 15, 2024
Added urls to tests to be consistent
There are still some tests with missing urls. |
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 16, 2024
Added url to ide-projects/build and removed try-catch-block
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 16, 2024
This reverts commit e583e1c.
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 16, 2024
Added url to ide-projects/build and removed try-catch-block
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 16, 2024
This reverts commit 2159590.
leonrohne27
pushed a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 16, 2024
Added url to ide-projects/build and removed try-catch-block
leonrohne27
added a commit
to leonrohne27/IDEasy
that referenced
this issue
Oct 16, 2024
Added url to ide-projects/build and removed try-catch-block
blizzarac
added a commit
to blizzarac/IDEasy
that referenced
this issue
Oct 27, 2024
* 'main' of github.com:blizzarac/IDEasy: devonfw#533: Add autocompletion of exit in ide shell (devonfw#707) Update advanced-tooling-windows.adoc simplify FlagProperty usage and allow ToolCommandlets to have long options (devonfw#644) Update CHANGELOG.adoc: prepare 2024.10.001 devonfw#685: update dependencies, added missing deps to LICENSE.adoc, doc rework, jakarta migration (devonfw#686) devonfw#689: Added urls to tests (devonfw#695)
leonrohne27
added a commit
to leonrohne27/IDEasy
that referenced
this issue
Nov 4, 2024
hohwille
pushed a commit
that referenced
this issue
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
refined
Issue in new state was discussed with the team and is clear
test
related to testing and QA
In PR #665 I introduced an improvement of our test infrastructure by removing some hack.
There I added this log message to spot and highlight inconsistent ide-projects and tests:
IDEasy/cli/src/test/java/com/devonfw/tools/ide/repo/ToolRepositoryMock.java
Line 39 in 51a16e1
If you now run all our tests you will find lots of such exceptions spamming our logs.
We need to get rid of this since it is indicating inconsistent test projects.
In order to fix this all we need to do is create the according tool versions in
urls
of the according project.The tool versions missing are reported in the exception message.
Examples how to fix this are included in PR #665 and can therefore be found in the diff (Files changed tab).
The job of this story is to complete this cleanup until all such errors are gone.
If that is the case, then please also remove the try catch block from the above linked code point so that in the future no further such inconsistencies can be created.
The text was updated successfully, but these errors were encountered: