Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance error messsages of ProcessBuilder #608

Closed
jan-vcapgemini opened this issue Sep 11, 2024 · 2 comments · Fixed by #653
Closed

Enhance error messsages of ProcessBuilder #608

jan-vcapgemini opened this issue Sep 11, 2024 · 2 comments · Fixed by #653
Assignees
@jan-vcapgemini
Labels
enhancement New feature or request process executing external programs (ProcessContext)
Milestone
release:2024.11.001

Comments

@jan-vcapgemini
Copy link
Contributor

jan-vcapgemini commented Sep 11, 2024 •
edited by hohwille
Loading

As an IDEasy user, I want to see what exactly failed when an application was not run successfully.

Currently IDEasy only shows the exit code of a failed process and omits the error messages in the log.

See:

IDEasy/cli/src/main/java/com/devonfw/tools/ide/process/ProcessContextImpl.java

Lines 284 to 287 in e73c7ae

private void performLogOnError(ProcessResult result, int exitCode, String interpreter) {
if (!result.isSuccessful() && (this.errorHandling != ProcessErrorHandling.NONE)) {
String message = createCommandMessage(interpreter, " failed with exit code " + exitCode + "!");

We could easily add result.getErr() here too.

UPDATE (JH): This should depend on ProcessMode so e.g. for DEFAULT all output was already redirected to the shell. However, for DEFAULT_CAPTURE we should output what has been captured (IMHO both stdout and stderr).
Somehow this is a duplicate or at least strongly overlaps with #593.
@jan-vcapgemini jan-vcapgemini added the enhancement New feature or request label Sep 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Sep 11, 2024
@jan-vcapgemini jan-vcapgemini self-assigned this Sep 11, 2024
@jan-vcapgemini jan-vcapgemini moved this from 🆕 New to 🏗 In progress in IDEasy board Sep 11, 2024
@hohwille hohwille mentioned this issue Sep 12, 2024
Closed
2 tasks
@hohwille
Copy link
Member

What is the status here?
According to #593 most of this issue is already implemented.

@hohwille hohwille added the process executing external programs (ProcessContext) label Sep 23, 2024
@hohwille
Copy link
Member

IMHO #593 problem went away since output is not captured anymore.
But in case of capture this story still needs to be implemented.

jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Sep 25, 2024
@jan-vcapgemini
devonfw#608: enhanced error messages
7bbea6e 
added test for enhanced error messages
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Sep 25, 2024
@jan-vcapgemini
devonfw#608: implemented requested changes
19b17d0 
added outs to error message
added check for DEFAULT_CAPTURE to start performLogOnError
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Sep 25, 2024
@jan-vcapgemini
devonfw#608: Adjusted out and error format
91d64ab 
reformatted process out and error messages
added test with expected Exception and error messages
added test resources
@jan-vcapgemini jan-vcapgemini mentioned this issue Sep 25, 2024
Merged
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Sep 25, 2024
@jan-vcapgemini
devonfw#608: added execute permissions to dotnet
867e62e
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 4, 2024
@jan-vcapgemini
devonfw#608: applied refactorings and fixes
8b60102 
refactored eclipse log method into ProcessResult
added log method to ProcessResult
optimized performLogOnError to use logger with proper log levels instead of custom messages
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 4, 2024
@jan-vcapgemini
devonfw#608: fixed test
7e89d36 
made sure that context runs on windows to detect dotnet.cmd properly
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 4, 2024
@jan-vcapgemini
devonfw#608: fixed test
b786464 
moved dotnet.cmd to windows folder
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 7, 2024
@jan-vcapgemini
devonfw#608: optimized Dotnet test
11dfda2 
moved windows test to parameterized tests
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 7, 2024
@jan-vcapgemini
devonfw#608: fixed tests
88b1475 
added missing javadocs
fixed dotnet windows test script
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 7, 2024
@jan-vcapgemini
devonfw#608: fixed Dotnet windows test
20bd7c6 
renamed dotnet.cmd to dotnet.exe
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 8, 2024
@jan-vcapgemini
devonfw#608: fixed tests
7a0433a 
fixed DotNet test
added run test to NpmTest
removed unused test resource files
renamed readme files to .gitkeep
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 15, 2024
@jan-vcapgemini
devonfw#608: fixed tests
bbb4c89 
made dotnet.exe executable
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 15, 2024
@jan-vcapgemini
devonfw#608: fixed tests
5d7f6af 
adjusted DotnetTest
adjusted NpmTest
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 17, 2024
@jan-vcapgemini
devonfw#608: disabled tests
b1ef58e 
disabled dotnet run tests on CI
disabled npm run test
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 21, 2024
@jan-vcapgemini
devonfw#608: implemented requested changes
42f59f5 
removed SubLogger
moved throw of exceptions after logger
optimized out and err creation
removed level checks for logger
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 21, 2024
@jan-vcapgemini
devonfw#608: fixed test
1e4b116 
re-added logging of exitcode on proper log level
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 24, 2024
@jan-vcapgemini
devonfw#608: implemented requested changes
68770c7 
removed duplicated log messages
removed ProcessResult.run hack
fixed and cleaned up tests
renamed ProcessConttextUnderTest
added new log method with 2 log levels to ProcessResult
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 24, 2024
@jan-vcapgemini
devonfw#608: added changes to changelog
39400c5
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 28, 2024
@jan-vcapgemini
devonfw#608: fixed tests
858ffca 
enforced log output of test scripts even if processMode was BACKGROUND
@hohwille hohwille added this to the release:2024.11.001 milestone Oct 29, 2024
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 30, 2024
@jan-vcapgemini
devonfw#608: implemented requested changes
c7f2c55 
removed hacks
jan-vcapgemini added a commit to jan-vcapgemini/IDEasy that referenced this issue Oct 30, 2024
@jan-vcapgemini
devonfw#608: moved changelog entry to new version
e95034a
hohwille pushed a commit that referenced this issue Oct 31, 2024
@jan-vcapgemini
#608: enhance error messages (#653)
39d1434
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in IDEasy board Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-vcapgemini jan-vcapgemini

Labels
enhancement New feature or request process executing external programs (ProcessContext)
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.11.001
Development

Successfully merging a pull request may close this issue.

#608: enhance error messages jan-vcapgemini/IDEasy
2 participants
@hohwille @jan-vcapgemini