devonfw#608: fixed tests

added missing javadocs fixed dotnet windows test script
jan-vcapgemini · Oct 7, 2024 · 88b1475 · 88b1475
1 parent 11dfda2
commit 88b1475
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 4 deletions.
diff --git a/cli/src/main/java/com/devonfw/tools/ide/tool/dotnet/DotNet.java b/cli/src/main/java/com/devonfw/tools/ide/tool/dotnet/DotNet.java
@@ -6,6 +6,10 @@
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.tool.LocalToolCommandlet;
 
+/**
+ * {@link LocalToolCommandlet} for <a href="https://docs.microsoft.com/en-us/dotnet/core/tools/">dotnet</a>. The .NET CLI (Command Line Interface)
+ * cross-platform tool for building, running, and managing .NET applications.
+ */
 public class DotNet extends LocalToolCommandlet {
 
   /**

diff --git a/cli/src/test/java/com/devonfw/tools/ide/process/ProcessContextImplTest.java b/cli/src/test/java/com/devonfw/tools/ide/process/ProcessContextImplTest.java
@@ -209,10 +209,10 @@ public void processWarningAndErrorShouldBeLogged(ProcessErrorHandling processErr
   }
 
   @Test
-  public void enablingCaptureShouldRedirectAndCaptureStreamsWithErrorsCorrectly() throws Exception {
+  public void enablingCaptureShouldRedirectAndCaptureStreamsWithErrorsCorrectly() {
     // arrange
     IdeTestContext context = newContext("processcontext");
-    SystemInfo systemInfo = SystemInfoMock.of("windows");
+    SystemInfo systemInfo = SystemInfoMock.of("linux");
     context.setSystemInfo(systemInfo);
 
     // act

diff --git a/cli/src/test/java/com/devonfw/tools/ide/tool/dotnet/DotNetTest.java b/cli/src/test/java/com/devonfw/tools/ide/tool/dotnet/DotNetTest.java
@@ -10,6 +10,9 @@
 import com.devonfw.tools.ide.os.SystemInfo;
 import com.devonfw.tools.ide.os.SystemInfoMock;
 
+/**
+ * Integration test of {@link DotNet}.
+ */
 public class DotNetTest extends AbstractIdeContextTest {
 
   private static final Path PROJECTS_TARGET_PATH = Path.of("target/test-projects");

diff --git a/...rc/test/resources/ide-projects/dotnet/repository/dotnet/dotnet/default/windows/dotnet.cmd b/...rc/test/resources/ide-projects/dotnet/repository/dotnet/dotnet/default/windows/dotnet.cmd
@@ -1 +1,3 @@
-echo Dummy dotnet 6.0.419 on windows %*
+#!/bin/bash
+
+echo "Dummy dotnet 6.0.419 on windows $*"
diff --git a/.../dotnet/dotnet/default/windows/dotnet.cmd → ...sitory/dotnet/dotnet/default/linux/dotnet b/.../dotnet/dotnet/default/windows/dotnet.cmd → ...sitory/dotnet/dotnet/default/linux/dotnet
@@ -3,4 +3,4 @@ echo "content to stdout"
 echo "more content to stdout"
 echo >&2 "error message to stderr"
 echo >&2 "another error message to stderr"
-return 1
+exit 2