Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#37: Tool commandlet for visual studio code #538

Conversation

aBega2000
Copy link
Contributor

@aBega2000 aBega2000 commented Aug 14, 2024

Fixes #37

@aBega2000 aBega2000 self-assigned this Aug 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2024

Pull Request Test Coverage Report for Build 11019972842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 66.107%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeaBasedIdeToolCommandlet.java 2 72.17%
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java 6 73.91%
com/devonfw/tools/ide/tool/vscode/Vscode.java 7 85.33%
Totals Coverage Status
Change from base Build 11016084960: 0.2%
Covered Lines: 6105
Relevant Lines: 8890

💛 - Coveralls

@aBega2000 aBega2000 marked this pull request as ready for review August 23, 2024 08:47
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aBega2000 thanks for your PR. 👍
I have nothing to add to what @slskiba already left as review comments. Please address these review comments. Then we can resolve and merge.

@hohwille hohwille added this to the release:2024.09.001 milestone Aug 29, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aBega2000 Thanks for your rework and improvements. 👍
Still it turns out some details are not yet clear and your implementation needs further rework.
I left several review comments for you to address.
As I cannot put a review comment on an empty file:
Please try to avoid inconsistent test-data except for cases where you explicitly want to test how the software behaves in case or corrupt data.
A Empty file is not a valid JSON file.
Simply put {} into extensions.json and you are safe.
Your current "hack" code migrated from bash would also in this case insert `"extensions": "plugin1,plugin". This may let your JUnit pass but this is still invalid JSON and the real VSCode application would complain about it.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aBega2000 thanks for your rework. Looks very good already. 👍

One review comment was still not completed and I added some small hints for final improvement. We can merge when these are resolved.

Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I've added some CRs to resolve.

@hohwille hohwille assigned hohwille and jan-vcapgemini and unassigned aBega2000 Sep 17, 2024
@slskiba
Copy link
Contributor

slskiba commented Sep 18, 2024

CHANGELOG entry needs to be added for this PR still

jan-vcapgemini and others added 2 commits September 18, 2024 13:13
added vscode to changelog
adjusted vscode install test (added a recommendation to extensions.js and check if new recommendation was added)
@jan-vcapgemini jan-vcapgemini added vscode Microsoft visual studio code plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) labels Sep 18, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jan-vcapgemini thanks for taking over this PR and resolving the last review comments. 👍

Still added some suggestions but will simply apply and then merge.

CHANGELOG.adoc Outdated Show resolved Hide resolved
CHANGELOG.adoc Outdated Show resolved Hide resolved
@hohwille hohwille merged commit 824b5e9 into devonfw:main Sep 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) vscode Microsoft visual studio code
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Implement ToolCommandlet for Visual Studio Code
5 participants