#37: Tool commandlet for visual studio code

cli/src/main/java/com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java

@@ -10,7 +10,6 @@
 import com.devonfw.tools.ide.common.Tag;
 import com.devonfw.tools.ide.context.IdeContext;
 import com.devonfw.tools.ide.io.FileAccess;
-import com.devonfw.tools.ide.io.FileAccessImpl;
 import com.devonfw.tools.ide.tool.LocalToolCommandlet;
 import com.devonfw.tools.ide.tool.ide.IdeToolCommandlet;
 
@@ -164,10 +163,14 @@ protected boolean doInstall(boolean silent) {
 
   private void createExtensionFolder() {
     Path extensionFolder = this.context.getIdeHome().resolve("plugins").resolve(this.tool);
-    FileAccess fileAccess = new FileAccessImpl(this.context);
-    fileAccess.mkdirs(extensionFolder);
+    this.context.getFileAccess().mkdirs(extensionFolder);
   }
 
+  /**
+   * Method to install active plugins or to handle install for inactive plugins
+   *
+   * @param plugins as {@link Collection} of plugins to install.
+   */
   protected void installPlugins(Collection<PluginDescriptor> plugins) {
     for (PluginDescriptor plugin : plugins) {
       if (plugin.isActive()) {

cli/src/main/java/com/devonfw/tools/ide/tool/vscode/Vscode.java

@@ -1,7 +1,7 @@
 package com.devonfw.tools.ide.tool.vscode;
 
+import java.io.BufferedReader;
 import java.io.IOException;
-import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayList;
@@ -21,7 +21,6 @@
 import com.devonfw.tools.ide.tool.ide.IdeToolCommandlet;
 import com.devonfw.tools.ide.tool.plugin.PluginDescriptor;
 import com.devonfw.tools.ide.version.VersionIdentifier;
-import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.ObjectMapper;
 
 /**
@@ -86,12 +85,16 @@ private void doAddRecommendations(List<PluginDescriptor> recommendations) {
     ObjectMapper objectMapper = new ObjectMapper();
     Map<String, Object> recommendationsMap;
 
+    try (BufferedReader reader = Files.newBufferedReader(extensionsJsonPath)) {
+      recommendationsMap = objectMapper.readValue(reader, Map.class);
+    } catch (IOException e) {
+      throw new RuntimeException(e);
+    }
+
+    List<String> existingRecommendations = (List<String>) recommendationsMap.getOrDefault("recommendations", new ArrayList<>());
+
     try {
-      if (Files.exists(extensionsJsonPath) && Files.size(extensionsJsonPath) > 0) {
-        String content = Files.readString(extensionsJsonPath, StandardCharsets.UTF_8);
-        recommendationsMap = objectMapper.readValue(content, new TypeReference<Map<String, Object>>() {
-        });
-        List<String> existingRecommendations = (List<String>) recommendationsMap.getOrDefault("recommendations", new ArrayList<>());
+      if (Files.exists(extensionsJsonPath) && Files.size(extensionsJsonPath) > 0 && existingRecommendations.size() < recommendations.size()) {
 
         for (PluginDescriptor recommendation : recommendations) {
           if (!existingRecommendations.contains(recommendation.getId())) {
@@ -100,13 +103,15 @@ private void doAddRecommendations(List<PluginDescriptor> recommendations) {
         }
 
         recommendationsMap.put("recommendations", existingRecommendations);
-      } else {
+      } else if (existingRecommendations.size() > recommendations.size()) {
         List<String> newRecommendations = new ArrayList<>();
         recommendationsMap = new HashMap<>();
         for (PluginDescriptor recommendation : recommendations) {
           newRecommendations.add(recommendation.getId());
         }
         recommendationsMap.put("recommendations", newRecommendations);
+      } else {
+        this.context.info("All recommendations are already set");
       }
 
       objectMapper.writeValue(extensionsJsonPath.toFile(), recommendationsMap);

cli/src/test/java/com/devonfw/tools/ide/tool/vscode/VscodeTest.java

@@ -5,13 +5,16 @@
 import com.devonfw.tools.ide.context.AbstractIdeContextTest;
 import com.devonfw.tools.ide.context.IdeTestContext;
 
+/**
+ * Test of {@link Vscode} class.
+ */
 public class VscodeTest extends AbstractIdeContextTest {
 
   private static final String PROJECT_VSCODE = "vscode";
 
 
   @Test
-  public void testVscode() {
+  public void testVscodeInstall() {
 
     // arrange
     IdeTestContext context = newContext(PROJECT_VSCODE);
@@ -31,5 +34,8 @@ private void checkInstallation(IdeTestContext context) {
 
     assertThat(context.getSoftwarePath().resolve("vscode/.ide.software.version")).exists().hasContent("1.92.1");
     assertThat(context).logAtSuccess().hasMessage("Successfully installed vscode in version 1.92.1");
+
+    //check Recommendations
+    assertThat(context.getWorkspacePath().resolve(".vscode").resolve("extensions.json")).exists().hasContent("{\"recommendations\":[\"mockedPlugin2\"]}");
   }
 }

cli/src/test/resources/ide-projects/vscode/project/settings/vscode/plugins/mocedPlugin2.properties

@@ -0,0 +1,3 @@
+plugin_id=mockedPlugin2
+plugin_active=false
+tags=mocking