Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#689: Added url and removed try-catch-block #698

Merged
merged 18 commits into from
Nov 20, 2024

Conversation

leonrohne27
Copy link
Contributor

Fixes: #689
Added url to ide-projects/build and removed try-catch-block

Added url to ide-projects/build and removed try-catch-block
@leonrohne27 leonrohne27 added the test related to testing and QA label Oct 16, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11932760876

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 67.249%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/url/model/UrlMetadata.java 1 83.87%
com/devonfw/tools/ide/version/VersionIdentifier.java 1 87.33%
com/devonfw/tools/ide/log/IdeLogger.java 2 67.39%
Totals Coverage Status
Change from base Build 11910441375: -0.04%
Covered Lines: 6396
Relevant Lines: 9170

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonrohne27 thanks for your PR and fixing this. Great work: you removed the "hack" and all tests are still green. 👍
Before we merge, I would like to discuss how we handle such test urls files.
Its seems you have copied the urls file of Java to all the other tools and then the URL in there does not make any sense. So:

  • should we either have a generic dummy URL in all these files?
  • or should we have something reasonable there? And if so should that include both the tool and its version in the URL? Or is that all pointless since that URL is most likely never ever relevant in the test and will always be ignored.

I was quite lax in the beginning but after we ended up in a partial mess of quite inconsistent test-data that sooner or later broke our tests, I want to think a step further.
However, IMHO it is also fine to go for a simply dummy URL for all these files but lets discuss and agree in the team first.
Apart from that all is fine and ready for merge.

@hohwille
Copy link
Member

hohwille commented Oct 21, 2024

Before we merge, I would like to discuss how we handle such test urls files...

I have created issue #706 for the idea of serving the software as compressed archive via wiremock.
As a preparation the suggested format for the urls files is as written in that issue:

${testbaseurl}/download/«tool»/«edition»/«version»/«tool»-«version».tgz

The values for «tool», «edition» and «version» need to be filled in while ${testbaseurl} remains as variable in the files and will later be resolved dynamically by implementation of #706.

I have created an example (see commit linked below) for such urls file in your PR.

@hohwille hohwille self-assigned this Oct 28, 2024
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@leonrohne27 leonrohne27 modified the milestone: release:2024.11.001 Nov 5, 2024
@jan-vcapgemini jan-vcapgemini removed their assignment Nov 18, 2024
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonrohne27 thanks for changing all the URLs. 👍
For Java I changed .jar to .tgz extension.
Now ready for merge.

@hohwille hohwille merged commit b737f83 into devonfw:main Nov 20, 2024
3 checks passed
@hohwille hohwille added this to the release:2024.12.001 milestone Nov 20, 2024
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. test related to testing and QA
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

fix ide-projects to be consisent for tests
4 participants