Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infinity loop opening windows in setup.bat #1017

Closed
hohwille opened this issue Dec 15, 2022 · 1 comment · Fixed by #1018
Closed

infinity loop opening windows in setup.bat #1017

hohwille opened this issue Dec 15, 2022 · 1 comment · Fixed by #1018
Labels
bug Something isn't working
Milestone
release:2022.12.001

Comments

@hohwille
Copy link
Member

I did not test the setup.bat for a longer time but now I did and got an ugly infinity loop endlessly opening CMD windows:
image

The problem comes from PR #883 that tries to detect if run from powershell.
@hohwille hohwille added bug Something isn't working Team_IDE labels Dec 15, 2022
@hohwille hohwille added this to the release:2022.12.001 milestone Dec 15, 2022
hohwille added a commit to hohwille/ide that referenced this issue Dec 15, 2022
@hohwille
devonfw#1017: simple fix for infinity loop
ae5ab98
@hohwille hohwille mentioned this issue Dec 15, 2022
Merged
hohwille added a commit that referenced this issue Dec 15, 2022
@hohwille
#1017: simple fix for infinity loop (#1018)
86f4f14
@hohwille
Copy link
Member Author

hohwille commented Dec 15, 2022 •
edited
Loading

For the record: I had google cloud SDK installed (see #1004) what was triggering the error:

C:\Users\hohwille>echo %PSMODULEPATH%
C:\Users\hohwille\Documents\WindowsPowerShell\Modules;C:\Users\hohwille\AppData\Local\Google\Cloud SDK\google-cloud-sdk\platform\PowerShell

This also means that on my machine setup.bat will ALWAYS think that I am running from powershell so our check is not really smart:

ide/scripts/src/main/resources/setup.bat

Line 7 in 86f4f14

echo "%PSModulePath%" | findstr "%USERPROFILE%" >NUL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
release:2022.12.001
Development

Successfully merging a pull request may close this issue.

#1017: simple fix for infinity loop hohwille/ide
1 participant
@hohwille