Rancher Desktop Installation not detected - ide is trying to install

[maybeec]

Expected behavior

As a user, I want to use docker so that I can work on my current project task. Running devonfw docker I want to get the setup for docker runtime OR start the available installation OR being asked to update, if my existing rancher desktop installation is outdated.

Actual behavior

The devonfw ide does not detect the rancher desktop installation on windows and thus staring a setup resulting in an error (in my case) during installation, that "Rancher Desktop cannot be closed. Please close it manually and retry the installation".

Steps to reproduce (bug) / Use Case of feature request (enhancement)

1. Have Rancher Desktop installed (in my case v1.2.1)
2. Run devon docker on windows
3. You get a setup dialog although an installation is already available (which you might forgot :D).

Related/Dependent Issues

Comments/Hints:

Affected version:

• OS: Windows 10
• Console: Git Bash

[maybeec]

I have to admit, that I installed Rancher Desktop manually some time ago, which then was not detected by devonfw ide.
I uninstalled it ran the installation again by devonfw ide, which is not working even accross devonfw ide installations on my machine. Nonetheless, that means, that we might need another detection mechanism to be clear, that we don't try to reinstall rancher or even worth install rancher over docker desktop

[hohwille]

Checked here:

ide/scripts/src/main/resources/scripts/command/docker

Line 146 in 70baf93

function doIsRancherInstalled() {

Long time ago we were simply checking if docker command is available. We should re-add this to doSetup so if I already have docker installed (whatever way Rancher-Desktop, Docker-Desktop or an alternative we might not even know of) all should be fine as installing yet another docker does not seem to make sense. So lets just read-add this check again.

[Ttring]

I could not reproduce the problem as shown in the picture. What I did was: install Rancher Desktop 1.7.0 manually and then run docker desktop.

After Rancher Desktop installation via devon, the environment variables "$PATH" is not updated for git bash. If devon docker is rerun without resetting the terminal, the script will conclude that Rancher Desktop is still not installed ($PATH is used here for detection) and hence, another Rancher Desktop installation will start again. The initial idea was to refresh environment variable.
Calling devon after devon docker does not reset the $PATH.

ide/scripts/src/main/resources/scripts/devon

Line 14 in 70baf93

# initialize environment...