#1030: Rancher Desktop Installation not detected. #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check right at the beginning of doSetup if ANY docker installation exists. And if it does there is no setup needed. In case of Rancher the Vpn Kit installation will be ensured aswell.
github-actions
bot
added
bash
hohwille
reviewed
Feb 13, 2023
…llation-not-detected---ide-is-trying-to-install
hohwille
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
@Amueller36 thanks for this PR. Excellent work 👍
Ready for merge
…llation-not-detected---ide-is-trying-to-install
|
CLA check is haning, waiting for next change on master to merge and trigger rebuild/-check. |
…llation-not-detected---ide-is-trying-to-install
hohwille
changed the title
…llation-not-detected---ide-is-trying-to-install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1030
Added check right at the beginning of doSetup if ANY docker installation exists, the doSetup returns, because then no setup is required. In case of Rancher the Vpn Kit installation will be ensured aswell.