Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature conflict with software repositoriy and local shared software #191

Closed
hohwille opened this issue Aug 19, 2019 · 1 comment
Closed
Labels
config should be configurable or configuration change enhancement New feature or request scripts related to shell scripts (bash and CMD) software software-package with 3rd party products
Milestone

Comments

@hohwille
Copy link
Member

We have two advanced features:

  1. Remote software repository - see Ability to configure software downloads via settings config #98
  2. Shared local software cache - see ability to configure central software installation directory #152

However, if these two features are combined undesired things can happen. So to be precise:
The implementation of 2. needs to separate software per repository.
Unlike a maven repository we can not be sure that a combination of tool, version, and OS will lead to the same binary no matter what repository is configured for 1. The idea of 1. is actually for projects to provide a customized version of a tool (e.g. use Java from a different vendor, use Eclipse with a preinstalled set of plugins, etc.).
The feature 2. only makes sense if you mave multiple installations of devon-ide in parallel. Now if some of these installations use different configurations for 1. the devon-ide will accidentally use the software of the one also for the other even though they should be different.

To fix the issue the structure of the shared software folder for 2. needs to be extended to:

${DEVON_SOFTWARE_PATH}/${software_repo}/${software_name}/${software_version}

Where ${software_repo} is one of:

  • default if 1. is not used
  • some unique identifier for 2. - IMHO the hostname should already be sufficient. To be more reliable a hash of the entire URL could be appended.
@hohwille hohwille added enhancement New feature or request scripts related to shell scripts (bash and CMD) software software-package with 3rd party products config should be configurable or configuration change labels Aug 19, 2019
@hohwille hohwille added this to the release:3.0.0 milestone Aug 19, 2019
hohwille added a commit that referenced this issue Aug 20, 2019
#178: also use reg import for uninstall avoiding admin rights
#191: fixed conflict with repo and shared software
#198: power-shell improvement
#199: also remove devon.bat on uninstall
#200: update installed devon[.bat] if newer
#202: fixed version compare and added tests
#203: workaround as cp -u is not working on MacOS
@hohwille
Copy link
Member Author

Fixed with PR #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config should be configurable or configuration change enhancement New feature or request scripts related to shell scripts (bash and CMD) software software-package with 3rd party products
Projects
None yet
Development

No branches or pull requests

1 participant