Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Still getting duplicated or undesired warnings for missing settings #200

Closed
hohwille opened this issue Aug 20, 2019 · 5 comments
Closed

Still getting duplicated or undesired warnings for missing settings #200

hohwille opened this issue Aug 20, 2019 · 5 comments
Labels
bug Something isn't working scripts related to shell scripts (bash and CMD) windows specific for Microsoft Windows OS
Milestone
release:3.2.0

Comments

@hohwille
Copy link
Member 

*** ATTENTION ***
Your devon-ide is missing the settings at
Please run the following command to complete your IDE setup:
devon ide setup [<settings-url>]
devon-ide environment variables have been set for C:\projects\cool-project

This also happens if the settings (here C:\projects\cool-project\settings) actually exist.
@hohwille hohwille added this to the release:3.0.0 milestone Aug 20, 2019
@hohwille hohwille added bug Something isn't working scripts related to shell scripts (bash and CMD) windows specific for Microsoft Windows OS labels Aug 20, 2019
@hohwille
Copy link
Member Author

As you can see here:

Your devon-ide is missing the settings at

and here:
https://github.com/devonfw/devon-ide/blob/c1eea27ef10e9cc21dc5a870f31d74f6e8efac88/scripts/src/main/resources/scripts/environment-project.bat#L30

The actual bug is that SETTINGS_PATH is undefined in this case.

@hohwille
Copy link
Member Author

The root cause after debugging seems to be that in this case DEVON_IDE_HOME is not set.
As a consequence all devon.properties are not found and hence also SETTINGS_PATHis not set.

@hohwille
Copy link
Member Author

Funny. The problem is that devon.bat has changed and once installed it does not get updated and overwritten. Seems we need the same check we introduced for linux/mac also for windows that checks if we have a newer version of devon script and then overwrites the older one.
However, in the future devon script needs to stay stable and should not change anymore if possible...

This was referenced Aug 20, 2019
Merged
Closed
hohwille added a commit that referenced this issue Aug 20, 2019
@hohwille
Various fixes and improvements (#201)
8ce2b41 
#178: also use reg import for uninstall avoiding admin rights
#191: fixed conflict with repo and shared software
#198: power-shell improvement
#199: also remove devon.bat on uninstall
#200: update installed devon[.bat] if newer
#202: fixed version compare and added tests
#203: workaround as cp -u is not working on MacOS
@hohwille
Copy link
Member Author

See also #177

@hohwille
Copy link
Member Author

Fixed with PR #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working scripts related to shell scripts (bash and CMD) windows specific for Microsoft Windows OS
Projects
None yet
Milestone
release:3.2.0
Development

No branches or pull requests
1 participant
@hohwille