-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First install removes all folders from user path #954
Comments
This is a duplicate of #409. |
I updated everything and tested again. The
OUTPUT LOGS
|
@RichardLinde thanks for your feedback and helping to improve devonfw-ide. From your logs there is nothing to see helping us to see what is wrong. The bug must come from the windows CMD magic to read and write the
These 3 lines try to determine the current
As a result you end up inside this
Could you simply revert your
Simply double-click on the On my machine this is working and giving me the proper |
I digged deep in our issues and this seems to be a duplicate of #393 that was closed because we could not reproduce it and got no feedback. Great if we now have the chance to understand and fix this issue with your help @RichardLinde |
Okay sound good.
running the test.bat file worked and gave the following output
This is my complete Path System + User
My testingI added a bit to the test.bat simulating the if statement to test if the folder is already set.
Result
The path is gone inside the if block. |
I ran the |
Did you already try this? So is Or is the |
Reading again both of your answers. |
So something is really inconsistent here. I tested the removal of the last semicolon and it works:
Therefore the
Here there is no trailing semicolon and therefore the So to summarize once again: |
@markusschuh Sorry to bother you but this magic command to read the |
In my research, I found that this may be where the problem is: https://stackoverflow.com/questions/10558316/example-of-delayed-expansion-in-batch-file So, if this causes the problem, we could either move the I tried this solution and it worked for me. |
I tested again. Everything works, as long as there is no if block around the code. Working without if blockResult:
Not working with if blockResult:
Working using !Result:
|
@RichardLinde thanks for your support, testing and feedback. And thanks @alfeilex for nailing down the problem. |
@RichardLinde Would you be so kind as to test our fix on your system? Here is the branch with the included fix. https://github.com/alfeilex/ide/tree/fix-devon.bat So all you have to do is replace the If you have any questions, please feel free to contact me. Thank you very much. |
With the update, the installation is working as expected, appending to the path variable instead of overwriting. |
@RichardLinde thanks again for your great support in reporting the bug and testing so we could finally trace it down. |
Expected behavior
When first installing the ide I want to use it to add other programs/tools to my already existing programs.
For example, I already had VSCode installed and wanted to use the ide for the first time to install Rancher Desktop.
Actual behavior
When running the
start.bat
for the first time while%USERPROFILE%\scripts
is not added to the user path the installation will instead of adding it to the path replace the path with it. Removing all folders from the path.In my example the command
code
was removed and had to be added again.Steps to reproduce
2.1 Uninstall devon ide
devon uninstall ide
2.2 Remove
%USERPROFILE%\scripts
from user pathstart.bat
Related/Dependent Issues
Comments/Hints:
Already talked about the issue with @cinnamon-coder-hub
Affected version:
Version: 2022.08.003
OS: Windows 10.0.19044 Build 19044
The text was updated successfully, but these errors were encountered: