#1066: devon.bat stopped adding PATH #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bash
hohwille
added
enhancement
hohwille
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
@alfeilex Awesome. Thanks for your fast analysis and this PR with a fix. 👍
This is really great. I already moved this from draft to ready for review and hereby approve it.
I have locally updated my devon.bat with your fixed version and tested it with several combinations. It looks good to me. I hope that #954 remains fixed.
hohwille
added a commit
that referenced
this pull request
Mar 9, 2023
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the error caused by PR #975.
How the fix works:
It removes the delayed expansion and uses an external label to fix the error provided by issue #954
Related issue: #1066