Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feature to vscode - recommended plugin installation #982

Closed
3 tasks done
alfeilex opened this issue Nov 16, 2022 · 3 comments · Fixed by #993
Closed
3 tasks done

Add new feature to vscode - recommended plugin installation #982

alfeilex opened this issue Nov 16, 2022 · 3 comments · Fixed by #993
Assignees
Labels
enhancement New feature or request vscode Microsoft visual studio code

Comments

@alfeilex
Copy link
Member

alfeilex commented Nov 16, 2022

In the past, when installing vscode, the devonfw-extentions-pack was automatically installed. This plugin installs ~60 additional extensions and takes some time to complete the installation of all of extensions. This causes errors for the nightly tests and perhaps, more importantly, not every user wants to have this plugin installed by default. So the idea is to add an option in the vscode command to install vscode without devofw-exetnsions-pack.

The new option should be to recommend plugins to the user after opening it. One possible way would be to add an entry like Recommend=true in the properties file. Here is the description of how to implement the whole thing for vscode.

However, the default should be that the plugin is installed automatically, the recommendation is just an option.

  • DoD
  • Adding the option to recommend plugins to the user
  • Adjusting the vscode documentation
@alfeilex alfeilex added enhancement New feature or request vscode Microsoft visual studio code Team_IDE draft needs clarification or details, not ready for implementation labels Nov 16, 2022
@hohwille
Copy link
Member

hohwille commented Nov 17, 2022

To follow the naming of our plugin properties files the option should rather be:

plugin_recommended=true

Please notice: The "recommendation" of a plugin is a VSCode specific feature that will give a "grown popup notification" informing the end-user that there is a recommended plugin the user should install and he can then choose to do so manually or he can reject.
When implementing this please do not forget to update the documentation:
https://github.com/devonfw/ide/blob/7f58a1fa39e77adce4a56e1f62d790faf2fa2507/documentation/vscode.asciidoc#plugins

@hohwille hohwille changed the title Add new feature to vscode - optional plugin installation Add new feature to vscode - recommended plugin installation Nov 18, 2022
@alfeilex alfeilex removed the draft needs clarification or details, not ready for implementation label Nov 21, 2022
@alfeilex
Copy link
Member Author

While implementing this feature, I have the following idea. When vscode is set up the doAddPlugins function

function doAddPlugins() {
will install all plugins configured in the ide settings. Maybe it makes more sense to add deactivated plugins automatically as "recommended". As a result we don't need an additional property.

Furthermore, we could add a new option devon vscode clean-setup which installs vscode without any plugins and recommendations. This feature can be used by the user and we can use this for nightly testing.

The function is already implemented in PR #990. I need feedback to add this feature to the documenation and complete the PR.

@alfeilex
Copy link
Member Author

The documentation has been updated, but we still need to dicuss how detailed we need to explain this feature in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode Microsoft visual studio code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants