Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#887: Temporary fixed vscode nightly test #981

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Nov 16, 2022

This PR fixed the nightly test for vscode. The nightly test failed, because the devonfw-extension-pack plugin was installed automatically and reached the timeout of github actions.

This fix belongs to related issue: #887

A new issue: 982 was created to extend the vscode commandlet so that the workaround is no longer necessary.

@github-actions github-actions bot added bash related to bash shell or scripts scripts related to shell scripts (bash and CMD) test related to testing and QA labels Nov 16, 2022
@alfeilex alfeilex marked this pull request as ready for review November 16, 2022 18:17
@hohwille hohwille changed the title 887: Temporary fixed vscode nightly test #887: Temporary fixed vscode nightly test Nov 18, 2022
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for the quickfix. 👍
Once #982 is implemented, we can decide to remove this again.

@hohwille hohwille added this to the internal milestone Nov 18, 2022
@hohwille hohwille merged commit e70a2d0 into devonfw:master Nov 18, 2022
@alfeilex alfeilex deleted the fix-vscode-test branch November 20, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash related to bash shell or scripts scripts related to shell scripts (bash and CMD) test related to testing and QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check VSCode Plugins - devonfw-extension-pack fails to install due to timeout
2 participants