Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to require minimum devonfw-ide version #999

Closed
hohwille opened this issue Dec 1, 2022 · 3 comments · Fixed by #1064
Closed

Ability to require minimum devonfw-ide version #999

hohwille opened this issue Dec 1, 2022 · 3 comments · Fixed by #1064
Assignees
Labels
enhancement New feature or request setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) update related to updating software or the entire devonfw-ide

Comments

@hohwille
Copy link
Member

hohwille commented Dec 1, 2022

As a ide admin, I want to configure a minimum devonfw-ide version so that I can use a new feature and ensure that users with too old version of devonfw-ide will get notified and can update automatically.

Idea:
Add this do my settings/devon.properties:

DEVON_IDE_VERSION=2023.01.001

(Better name it DEVON_IDE_MIN_VERSION?)
Users with e.g. 2022.12.001 containing this new feature already will then get this result when they setup devonfw-ide for the project:

Your version of devonfw-ide is currently 2022.12.001.
However, your project requires at least version `2023.01.001`.
Newer features will be required for your project so you need to update your devonfw-ide via the following command:
devon ide update scripts
Do you want to run the update now, so you can rerun "devon ide setup" after that? (yes/no)

Side-node: Obviously this only works if you have at least a devonfw-ide version supporting this feature. This is planned for 2022.12.001 (see milestone) so one fine day in the future when all older versions have been washed away, the feature can be used reliably.

@hohwille hohwille added the enhancement New feature or request label Dec 1, 2022
@hohwille
Copy link
Member Author

hohwille commented Dec 1, 2022

Note: Actually only on windows this has to abort the setup due to file locking issues devon ide update will therefore exit on windows terminating the further process of our ide commandlet calling the functionality.

@hohwille hohwille added setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) update related to updating software or the entire devonfw-ide Team_IDE labels Dec 1, 2022
@hohwille hohwille added this to the release:2022.12.001 milestone Dec 1, 2022
@hohwille
Copy link
Member Author

hohwille commented Dec 1, 2022

A good place where to add this check would be here:
https://github.com/devonfw/ide/blob/master/scripts/src/main/resources/scripts/command/ide#L235

@hohwille hohwille removed this from the release:2022.12.001 milestone Dec 15, 2022
@Ttring Ttring self-assigned this Jan 1, 2023
Ttring added a commit to Ttring/ide that referenced this issue Jan 8, 2023
@mustafaokyay mustafaokyay assigned CREITZ25 and Oumal1 and unassigned Ttring Jan 30, 2023
Oumal1 added a commit to Oumal1/ide that referenced this issue Feb 7, 2023
@hohwille hohwille linked a pull request Mar 13, 2023 that will close this issue
@hohwille hohwille added this to the release:2023.03.001 milestone Mar 13, 2023
hohwille added a commit to hohwille/ide that referenced this issue Mar 13, 2023
@hohwille
Copy link
Member Author

Retested with latest release successful:

******** ATTENTION ********
Your version of devonfw-ide is currently 2023.03.001
However this is too old as your project requires at latest version 2023.03.002
Please run the following command to update to the latest version of devonfw-ide and fix the problem before rerunning setup:

devon ide update scripts


We are sorry for the inconvenience. Please check the above errors, resolve them and try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) update related to updating software or the entire devonfw-ide
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants