#999: add feature to check minimum require version #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bash
hohwille
requested changes
Jan 17, 2023
| current_devon_version="$("${DEVON_HOME_DIR}/scripts/devon.bat" -v)" | ||
| min_devon_ide_version_month=${DEVON_IDE_MIN_VERSION##${DEVON_IDE_MIN_VERSION%%.*}.} | ||
| current_devon_version_month=${current_devon_version##${current_devon_version%%.*}.} | ||
| if [[ ${DEVON_IDE_MIN_VERSION%%.*} -gt ${current_devon_version%%.*} ]] |
There was a problem hiding this comment.
we should use doVersionCompare for this as -gt is not suitable for comparing versions. In the worst case, we later have to change versioning schema again (see devonfw Teams discussion) and this will break and stop working.
Comment on lines
+49
to
+56
| local update_version | ||
| if [ -z "${1}" ] | ||
| then | ||
| update_version="LATEST" | ||
| else | ||
| update_version=${1} | ||
| fi | ||
| doUpgradeMavenArtifact "${DEVON_IDE_HOME}" "${DEVON_IDE_REPO_URL}" "devonfw-ide-scripts" "${update_version}" ".tar.gz" "${devon_ide_version}" |
There was a problem hiding this comment.
I do not see how this relates to #999.
Here we do update to a new version while checking for a minimum required version should happen during the setup after the settings are cloned and devon.properties are read.
Comment on lines
+264
to
+274
| read -r -p "(yes/no): " answer | ||
| if [ "${answer}" = "yes" ] || [ -z "${answer}" ] | ||
| then | ||
| doUpdateScripts "${DEVON_IDE_MIN_VERSION}" | ||
| doEcho "Version ${target_version} had been successfully downloaded. Please rerun 'devon ide setup' to complete the setup." | ||
| return 0 | ||
| elif [ "${answer}" = "no" ] | ||
| then | ||
| doEcho "\nUpdate to the minimum required version is aborted.\nTo complete the setup, please run 'devon ide update scripts' then rerun 'devon ide setup'." | ||
| return 1 | ||
| fi |
There was a problem hiding this comment.
function doAskToContinue already does this job and can be reused.
Comment on lines
+276
to
+312
| if [ ${min_devon_ide_version_month%%.${DEVON_IDE_MIN_VERSION##*.}} -gt ${current_devon_version_month%%.${current_devon_version##*.}} ] | ||
| then | ||
| doEcho "\nYour version of devonfw-ide is currently '${current_devon_version}'" | ||
| doEcho "However, your project requires at least version '${DEVON_IDE_MIN_VERSION}'." | ||
| doEcho "Newer features will be required for your project so you need to update your devonfw-ide via the following command:" | ||
| doEcho "'devon ide update scripts'" | ||
| doEcho "Do you want to run the update now, so you can rerun 'devon ide setup' after that?" | ||
| read -r -p "(yes/no): " answer | ||
| if [ "${answer}" = "yes" ] || [ -z "${answer}" ] | ||
| then | ||
| doUpdateScripts "${DEVON_IDE_MIN_VERSION}" | ||
| doEcho "Version ${target_version} had been successfully downloaded. Please rerun 'devon ide setup' to complete the setup." | ||
| return 0 | ||
| elif [ "${answer}" = "no" ] | ||
| then | ||
| doEcho "\nUpdate to the minimum required version is aborted.\nTo complete the setup, please run 'devon ide update scripts' then rerun 'devon ide setup'." | ||
| return 1 | ||
| fi | ||
| fi | ||
| if [ ${DEVON_IDE_MIN_VERSION##*.} -gt ${current_devon_version##*.} ] | ||
| then | ||
| doEcho "\nYour version of devonfw-ide is currently '${current_devon_version}'" | ||
| doEcho "However, your project requires at least version '${DEVON_IDE_MIN_VERSION}'." | ||
| doEcho "Newer features will be required for your project so you need to update your devonfw-ide via the following command:" | ||
| doEcho "'devon ide update scripts'" | ||
| doEcho "Do you want to run the update now, so you can rerun 'devon ide setup' after that?" | ||
| read -r -p "(yes/no): " answer | ||
| if [ "${answer}" = "yes" ] || [ -z "${answer}" ] | ||
| then | ||
| doUpdateScripts "${DEVON_IDE_MIN_VERSION}" | ||
| doEcho "Version ${target_version} had been successfully downloaded. Please rerun 'devon ide setup' to complete the setup." | ||
| return 0 | ||
| elif [ "${answer}" = "no" ] | ||
| then | ||
| doEcho "\nUpdate to the minimum required version is aborted.\nTo complete the setup, please run 'devon ide update scripts' then rerun 'devon ide setup'." | ||
| return 1 | ||
| fi |
There was a problem hiding this comment.
This is highly redundant and should be reworked.
|
This PR is replaced by #1056 so the work is not lost and the story will be completed. Hence, I can now close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test it,
DEVON_IDE_MIN_VERSION=2023.01.001needs to be added in settings\properties.If the current Devon version is smaller than the minimum required version, it is updated to the minimum required version.
If the current Devon version is greater than the minimum required version, it remains at the current version.
If the given minimum version is not available, the operation is terminated with code 22.