Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1004: GCloud CLI integration for windows #1028

Merged
merged 9 commits into from
Jan 17, 2023
Merged

#1004: GCloud CLI integration for windows #1028

merged 9 commits into from
Jan 17, 2023

Conversation

alfeilex
Copy link
Member

@alfeilex alfeilex commented Dec 29, 2022 •
edited
Loading

GCloud CLI is added to the ide as a commandlet. It only works for Windows systems as it requires Python to run. After Python is fixed for MacOS and Linux, we can update this command.

Related issue: #1004

@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD) labels Dec 29, 2022
@alfeilex alfeilex linked an issue Dec 29, 2022 that may be closed by this pull request
Support for gcloud CLI #1004
Closed
@alfeilex alfeilex changed the title #1004: GCloud CLI integration #1004: GCloud CLI integration for windows Jan 3, 2023
@alfeilex alfeilex added the windows specific for Microsoft Windows OS label Jan 3, 2023
@github-actions github-actions bot removed the windows specific for Microsoft Windows OS label Jan 3, 2023
@alfeilex alfeilex marked this pull request as ready for review January 5, 2023 07:38
hohwille
hohwille approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alfeilex thanks for the PR. Looks good to me and great that you could already solve it for windows. 👍

scripts/src/main/resources/scripts/command/gcloud Outdated Show resolved Hide resolved
@hohwille hohwille added this to the release:2023.01.001 milestone Jan 17, 2023
@hohwille hohwille merged commit 7f85671 into devonfw:master Jan 17, 2023
@alfeilex alfeilex deleted the feature/gcloud-integration branch January 18, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hohwille hohwille hohwille approved these changes

Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) documentation related to documentation (AsciiDoc) scripts related to shell scripts (bash and CMD)
Projects
None yet
Milestone
release:2023.01.001
Development

Successfully merging this pull request may close these issues.

Support for gcloud CLI
2 participants
@alfeilex @hohwille