#1065: Add SHA-256 checksum generator to url-updater #1089

alfeilex · 2023-03-30T12:57:30Z

No description provided.

Because the status json handling that was done before seemed wrong I refactored the corresponding methods/classes.

…009-Create-crawler-Create-1008-create-URL-checker

Updated Pom.xml

…irrors-1009-Create-crawler-Create-1008-create-URL-checker

…awler-Create-1008-create-URL-checker' of https://github.com/Amueller36/ide into feature-941-New-approach-for-ide-mirrors-1009-Create-crawler-Create-1008-create-URL-checker

…009-Create-crawler-Create-1008-create-URL-checker

…ling/UrlVersion.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>

Refactored UpdateManager Fixxed problem with HelmCrawler, which caused no versions to be found. Fixxed MavenCrawler not creating status.json files. Rancher now is part of the folder docker. Added support For Kotlin due to ticket devonfw#1039

…009-Create-crawler-Create-1008-create-URL-checker

Aligned Kotlin Native Convention with commandlet

…009-Create-crawler-Create-1008-create-URL-checker

…awler-Create-1008-create-URL-checker' of https://github.com/Amueller36/ide into feature-941-New-approach-for-ide-mirrors-1009-Create-crawler-Create-1008-create-URL-checker

sonatype-lift · 2023-03-30T13:01:02Z

url-updater/src/main/java/com/devonfw/tools/ide/url/updater/ChecksumGenerator.java

+                        throw new IllegalStateException("Failed to create checksum " + e);
+                    }
+
+                    try (BufferedWriter checksumFile = new BufferedWriter(new FileWriter(file + ".sha256"))) {


DefaultCharset: Implicit use of the platform default charset, which can result in differing behaviour between JVM executions or incorrect behavior if the encoding of the data source doesn't match expectations.

Suggested change

try (BufferedWriter checksumFile = new BufferedWriter(new FileWriter(file + ".sha256"))) {

try (BufferedWriter checksumFile = Files.newBufferedWriter(Paths.get(file + ".sha256"), Charset.defaultCharset())) {

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-30T13:01:06Z

url-updater/src/main/java/com/devonfw/tools/ide/url/updater/ChecksumGenerator.java

+
+    /**
+     * @param inputStream the input stream of requested url
+     * @return


EmptyBlockTag: A block tag (@param, @return, @throws, @deprecated) has an empty description. Block tags without descriptions don't add much value for future readers of the code; consider removing the tag entirely or adding a description.

Suggested change

* @return

*

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-30T13:01:08Z

url-updater/src/main/java/com/devonfw/tools/ide/url/updater/ChecksumGenerator.java

+     * start the generator to create checksums of .urls files
+     * @param files iterate over files to find .urls files
+     */
+    public void generateChecksums(File[] files) {


AvoidObjectArrays: Avoid accepting a File[]; consider an Iterable instead

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-30T13:01:11Z

url-updater/src/main/java/com/devonfw/tools/ide/url/updater/ChecksumGenerator.java

+                        throw new IllegalStateException("Failed to create checksum " + e);
+                    }
+
+                    try (BufferedWriter checksumFile = new BufferedWriter(new FileWriter(file + ".sha256"))) {


PATH_TRAVERSAL_OUT: This API (java/io/FileWriter.(Ljava/lang/String;)V) writes to a file whose location might be specified by user input

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-03-30T13:01:13Z

url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/jsonfile/URLStatus.java

+		return URLStatusSuccess;
+	}
+
+	public void setSuccess(URLStatusSuccess URLStatusSuccess) {


VariableNameSameAsType: Variable named URLStatusSuccess has the type URLStatusSuccess. Calling methods using "URLStatusSuccess.something" are difficult to distinguish between static and instance methods.

❗❗ 5 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

url-updater/src/main/java/com/devonfw/tools/ide/url/updater/AbstractCrawler.java 159

url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/jsonfile/URLStatus.java 22

url-updater/src/main/java/com/devonfw/tools/ide/url/updater/AbstractCrawler.java 132

url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/jsonfile/URLStatus.java 4

url-updater/src/main/java/com/devonfw/tools/ide/url/folderhandling/jsonfile/URLStatus.java 5

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

Amueller36 and others added 26 commits January 23, 2023 14:53

Crawler implemented And Refactored Status Json

57726c3

Because the status json handling that was done before seemed wrong I refactored the corresponding methods/classes.

Merge branch 'master' into feature-941-New-approach-for-ide-mirrors-1…

11d60da

…009-Create-crawler-Create-1008-create-URL-checker

Pom.xml update

6d722f0

Updated Pom.xml

Merge branch 'devonfw:master' into feature-941-New-approach-for-ide-m…

33f0484

…irrors-1009-Create-crawler-Create-1008-create-URL-checker

semicolon missing

43bb7fb

Merge branch 'feature-941-New-approach-for-ide-mirrors-1009-Create-cr…

6d5fc3c

…awler-Create-1008-create-URL-checker' of https://github.com/Amueller36/ide into feature-941-New-approach-for-ide-mirrors-1009-Create-crawler-Create-1008-create-URL-checker

Fixxed bug where files from repo were loaded that shouldnt be loaded

d177c21

Merge branch 'master' into feature-941-New-approach-for-ide-mirrors-1…

b6deba9

…009-Create-crawler-Create-1008-create-URL-checker

Update url-updater/src/main/java/com/devonfw/tools/ide/url/folderhand…

714e66d

…ling/UrlVersion.java Co-authored-by: sonatype-lift[bot] <37194012+sonatype-lift[bot]@users.noreply.github.com>

Added missing import caused by sonarlift

970e34a

Removed unused methods that are not needed anymore

e6462cb

Corrected additonal s in lift.toml

1bbd840

Removed potential Nullptr Dereference

795cb97

Merge branch 'master' into feature-941-New-approach-for-ide-mirrors-1…

2d0a61a

…009-Create-crawler-Create-1008-create-URL-checker

Merge branch 'master' into feature-941-New-approach-for-ide-mirrors-1…

7505c22

…009-Create-crawler-Create-1008-create-URL-checker

Added Kotlin/ Kotlin native Crawler

d867881

Added javadoc to important classes

731eecf

Fixxed Naming of intellij Edition folder.

6863e7e

Aligned Kotlin Native Convention with commandlet

Merge branch 'master' into feature-941-New-approach-for-ide-mirrors-1…

62c5346

…009-Create-crawler-Create-1008-create-URL-checker

Working on the reviews

11055d1

Merge branch 'feature-941-New-approach-for-ide-mirrors-1009-Create-cr…

b7c6e4e

…awler-Create-1008-create-URL-checker' of https://github.com/Amueller36/ide into feature-941-New-approach-for-ide-mirrors-1009-Create-crawler-Create-1008-create-URL-checker

Added Check in Updateinitiator for args

3a84432

add independent checksum generator

b17b118

add independent checksum generator

d8a963a

alfeilex linked an issue Mar 30, 2023 that may be closed by this pull request

compute checksum of binary downloads #1065

Closed

github-actions bot added bash related to bash shell or scripts settings ide-settings repo and replated processes and features labels Mar 30, 2023

sonatype-lift bot reviewed Mar 30, 2023

View reviewed changes

Create testing-checksum.yml

f7e8578

github-actions bot added the SCM software-configuration-management (github actions, internal processes, git or github utilization) label Mar 30, 2023

alfeilex closed this Apr 3, 2023

alfeilex deleted the checksum-generator-independent branch April 3, 2023 13:39

alfeilex removed a link to an issue Apr 3, 2023

compute checksum of binary downloads #1065

Closed

hohwille added this to the rejected milestone Aug 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1065: Add SHA-256 checksum generator to url-updater #1089

#1065: Add SHA-256 checksum generator to url-updater #1089

alfeilex commented Mar 30, 2023

sonatype-lift bot Mar 30, 2023

sonatype-lift bot Mar 30, 2023

sonatype-lift bot Mar 30, 2023

sonatype-lift bot Mar 30, 2023

sonatype-lift bot Mar 30, 2023

	try (BufferedWriter checksumFile = new BufferedWriter(new FileWriter(file + ".sha256"))) {
	try (BufferedWriter checksumFile = Files.newBufferedWriter(Paths.get(file + ".sha256"), Charset.defaultCharset())) {

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

#1065: Add SHA-256 checksum generator to url-updater #1089

#1065: Add SHA-256 checksum generator to url-updater #1089

Conversation

alfeilex commented Mar 30, 2023

sonatype-lift bot Mar 30, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 30, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 30, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 30, 2023

Choose a reason for hiding this comment

sonatype-lift bot Mar 30, 2023

Choose a reason for hiding this comment