-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute checksum of binary downloads #1065
Comments
For the record: Maven is already following this best practice approach as you can see here:
I would consider
|
We can probably also use the command I tested that command on
|
Currently, there are ~8000
then each of these files has a size of 100bytes. This would increase the size of repository to 781.25KB. That should be fine. |
With epic #941 we are redesigning our downloads and introducing ide-urls repo.
The idea of this story is to improve security and prevent man-in-the-middle or other attacks that may lead to downloads of evil content and therefore remote-code-execution.
To archive this, we will introduce checksum files (e.g. sha or md5) for all our downloads in ide-urls.
So in addition to downloading the actual package, we would also download the corresponding checksum file.
Then we would compute the checksum locally using an according tool (e.g.
sha256sum
ormd5sum
) and compare the result with the content of the downloaded checksum file.If they match, we continue as before, but otherwise, we would fail with an according error and a link with further instructions (AsciiDoc file with hints and link to report a security issue so we can also check if the vendor has actually changed the binary after releasing on purpose what is an anti-pattern but might also happen in rare cases).
NOTE: even though the feature is released with
2023.04.001
the actual verification of checksums is not yet implemented and will come with a following release. To track all this watch the epic #941.The text was updated successfully, but these errors were encountered: