Switching message on success to "Successfully <past>"

[ThomasRot]

Just a minor grammar fix as to my knowledge "succeed to " does not exist..

[hohwille]

@ThomasRot thanks for your PR and contributing to devonfw-ide.
Could you explain the rationale for your change?

Just a minor grammar fix as to my knowledge "succeed to " does not exist..

It actually is Succeeded to :

ide/scripts/src/main/resources/scripts/functions

Line 91 in 0812921

doSuccess "Succeeded to ${message}"

Further there are multiple places for this (you only changed one of them):

ide/scripts/src/main/resources/scripts/functions

Line 50 in 0812921

doSuccess "Succeeded to ${1}"

I checked the grammar:
https://www.collinsdictionary.com/dictionary/english/succeed

So it seems Succeeded is correct and Succeeded to also exists, but is not the correct form here as in Succeeded to the Succeeded means "inherited" like in

George III succeeded to the throne in 1760.

So actually correct grammar would be Succeeded in + verb in infinitive:

Succeeded in doing something

I was not aware of this detail of English grammar so thanks for your correction.

However, as we also use the message in present form for debug output before executing the command it also does not make sense to change it to the past form everywhere.
Instead I would simply change the message from Succeeded to to something more simple like Success: or Successfully performed .

[hohwille]

I have created PR #802 as a simple fix and replacement for this PR.
If OK, I would close this PR and merge #802 to resolve the actual issue.

[hohwille]

@ThomasRot beginning of next week I will close this PR and merge #802 unless you have anything else to report. We try to make continuous progress and releases (again after a time where I was M.I.A.).

[ThomasRot]

All good points especially as this change did not consider all implications. I like the solution proposed in #802, so I'm closing this one.