Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#798: English grammar fix for success message #802

Merged
merged 2 commits into from
Jun 24, 2022
Merged

#798: English grammar fix for success message #802

merged 2 commits into from
Jun 24, 2022

Conversation

hohwille
Copy link
Member

Alternative fix for PR #798

@hohwille hohwille added enhancement New feature or request setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup) labels Jun 23, 2022
@hohwille hohwille added this to the release:2022.04.004 milestone Jun 23, 2022
@github-actions github-actions bot added bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) scripts related to shell scripts (bash and CMD) labels Jun 23, 2022
@hohwille
Copy link
Member Author

Now produces output like this:

Success: verify installation of node.js ('/d/projects/devonfw/software/node/node.exe')

IMHO simple fix avoiding other problems when changing the time forms from present to past.

@hohwille hohwille mentioned this pull request Jun 23, 2022
Closed
@maybeec maybeec merged commit 94a9ff7 into devonfw:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bash related to bash shell or scripts commandlet related to commandlets (scripts/command/*) enhancement New feature or request scripts related to shell scripts (bash and CMD) setup related to the setup process of devonfw-ide (setup[.bat] and devon ... setup)
Projects
None yet
Milestone
release:2022.08.001
Development

Successfully merging this pull request may close these issues.
2 participants
@hohwille @maybeec