-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Helm Chart Local Installation Support #1088
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
feat-air-gapped
branch
from
September 14, 2022 11:03
331cbb9
to
592f8c5
Compare
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
daniel-hutao
force-pushed
the
feat-air-gapped
branch
from
September 14, 2022 11:18
592f8c5
to
34e8817
Compare
iyear
reviewed
Sep 14, 2022
iyear
reviewed
Sep 14, 2022
iyear
reviewed
Sep 14, 2022
iyear
reviewed
Sep 14, 2022
iyear
reviewed
Sep 14, 2022
iyear
reviewed
Sep 14, 2022
iyear
reviewed
Sep 14, 2022
iyear
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@iyear I've updated. Thanks for your great feedback. |
I‘m reviewing, please do not merge until my review is finished. |
aFlyBird0
requested changes
Sep 15, 2022
Signed-off-by: Daniel Hu <tao.hu@merico.dev>
@aFlyBird0 Please take a look again. I've merge the copy function in the commit c28ef1b. |
aFlyBird0
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
New feat with helm chart local installation
Related Issues
#1084
New Behavior (screenshots if needed)