Cmp instead of idb #2076
Merged
Cmp instead of idb #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfahlander
reviewed
Sep 27, 2024
src/classes/table/table.ts
Outdated
| function equals (a, b) { | ||
| return idb.cmp(a,b) === 0; // Works with all indexable types including binary keys. | ||
| return cmp(a, b); // Works with all indexable types including binary keys. |
There was a problem hiding this comment.
You mean cmp(a, b) === 0; ?
There was a problem hiding this comment.
dumb mistake on my part, fixed it. sorry about that
|
Thanks for the fix. I think this was the last place where we are using idb.cmp. If you have time, could you check if we could also get rid of the line |
|
I've checked it out and it's not being used anywhere else in table.ts, so removed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix issue #2064
What I've changed is basically the comparison function, from idb.cmp() to cmp() defined at src/functions/cmp.ts