Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmp instead of idb #2076

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Cmp instead of idb #2076

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4dc227
switching to cmp.ts in Table.where()
ankitjhaTP Sep 26, 2024
55b82fe
first commit
ankitjhaTP Sep 26, 2024
3939e77
fixing the oopsie
ankitjhaTP Sep 27, 2024
32ff4f0
removed const idb
ankitjhaTP Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/classes/table/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,9 @@ export class Table implements ITable<any, IndexableType> {
// Ok, now let's fallback to finding at least one matching index
// and filter the rest.
const { idxByName } = this.schema;
const idb = this.db._deps.indexedDB;

function equals (a, b) {
return idb.cmp(a,b) === 0; // Works with all indexable types including binary keys.
function equals(a, b) {
return cmp(a, b) === 0; // Works with all indexable types including binary keys.
}

const [idx, filterFunction] = keyPaths.reduce(([prevIndex, prevFilterFn], keyPath) => {
Expand Down
Loading