Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): update x/sys dependency #308

Merged
merged 2 commits into from
Oct 10, 2022
Merged

fix(build): update x/sys dependency #308

merged 2 commits into from
Oct 10, 2022

Conversation

joshua-goldstein
Copy link
Contributor

@joshua-goldstein joshua-goldstein commented Oct 10, 2022 •
edited
Loading

Problem

Build was failing on darwin/arm64. See here.

Solution

We update the dependency on x/sys.

> go get -u golang.org/x/sys
go: downloading golang.org/x/sys v0.0.0-20221010170243-090e33056c14
go: upgraded golang.org/x/sys v0.0.0-20200930185726-fdedc70b468f => v0.0.0-20221010170243-090e33056c14
> go mod tidy

@joshua-goldstein joshua-goldstein marked this pull request as ready for review October 10, 2022 19:07
@joshua-goldstein joshua-goldstein merged commit d2cbc2f into main Oct 10, 2022
@joshua-goldstein joshua-goldstein deleted the joshua/update-x-sys-dependency branch October 10, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmcneely matthewmcneely matthewmcneely approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@gcxml gcxml Awaiting requested review from gcxml

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshua-goldstein @matthewmcneely