Check existence, not value of identity for 1-1 relations #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In relations with type Backbone.One, _setAttr was checking that data's id has a truthy value before comparing the identity with currVal's. This means that if id's value is falsy, such as 0, the predicate fails even if the actual values were the same. By checking for the id's existence instead, we match things up correctly even with falsy identities.
dhruvaray
added a commit
that referenced
this pull request
Feb 25, 2014
Check existence, not value of identity for 1-1 relations
|
Thanks for the PR and the test case... Much appreciated! |
|
@arirahikkala Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relations with type Backbone.One, _setAttr was checking that data's id
has a truthy value before comparing the identity with currVal's. This
means that if id's value is falsy, such as 0, the predicate fails even if
the actual values were the same. By checking for the id's existence
instead, we match things up correctly even with falsy identities.