Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check existence, not value of identity for 1-1 relations #112

Merged
merged 1 commit into from
Feb 25, 2014
Merged

Check existence, not value of identity for 1-1 relations #112

merged 1 commit into from
Feb 25, 2014

Commits on Feb 25, 2014

  1. Check existence, not value of identity 

    In relations with type Backbone.One, _setAttr was checking that data's id
has a truthy value before comparing the identity with currVal's. This
means that if id's value is falsy, such as 0, the predicate fails even if
the actual values were the same. By checking for the id's existence
instead, we match things up correctly even with falsy identities.
    @arirahikkala
    arirahikkala committed Feb 25, 2014
    Configuration menu
    Copy the full SHA
    210f188 View commit details
    Browse the repository at this point in the history