remove ChromeFrame #6751
Closed
remove ChromeFrame #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,14 +6,14 @@ | |||
|
|
|||
| require ::File.expand_path('../config/environment', __FILE__) | |||
| require ::File.expand_path('../lib/unicorn_killer', __FILE__) | |||
| require ::File.expand_path('../lib/rack/chrome_frame', __FILE__) | |||
| require ::File.expand_path('../lib/rack/internet_explorer_version', __FILE__) | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
SuperTux88
force-pushed
the
internet-explorer-version-check
branch
from
2354b49 to
8a489da
Compare
| context "non-IE browser" do | ||
| let(:ua_string) { "another browser chromeframe" } | ||
|
|
||
| it "shouldn't complain about the browser and shouldn't have chrome frame" do |
There was a problem hiding this comment.
shouldn't have chrome frame
You don't test this here so I'd drop that part of the description.
Google Chrome Frame was a plugin for Internet Explorer, but is no longer supported. And it was included with http and not https which triggered a warning on most pods. Also set the minimum version to 9 to support diaspora#6557
SuperTux88
force-pushed
the
internet-explorer-version-check
branch
from
8a489da to
5dd6dcf
Compare
|
Merged as d97448e Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Chrome Frame was a plugin for Internet Explorer, but is no longer
supported. And it was included with http and not https which triggered a
warning on most pods.
Also set the minimum version to 9 to support #6557