Experimental ci with github actions #2269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
force-pushed
the
try/github_actions
branch
15 times, most recently
from
d267175
to
e75936d
Compare
|
|
weiznich
force-pushed
the
try/github_actions
branch
7 times, most recently
from
9240d7d
to
1e11e76
Compare
weiznich
commented
Jan 16, 2020
.github/workflows/doc.yml
Outdated
| if: success() | ||
| uses: JamesIves/github-pages-deploy-action@releases/v3 | ||
| with: | ||
| ACCESS_TOKEN: ${{ secrets.ACCESS_TOKEN }} |
There was a problem hiding this comment.
We need to create this token somewhere.
There was a problem hiding this comment.
seems like it is under the repo settings if you are an admin?
weiznich
commented
Jan 16, 2020
| with: | ||
| ACCESS_TOKEN: ${{ secrets.ACCESS_TOKEN }} | ||
| BRANCH: gh-pages # The branch the action should deploy to. | ||
| FOLDER: target/doc # The folder the action should deploy. |
There was a problem hiding this comment.
This means we need to change the documentation link on our web page
|
This seems to work now modulo the expected nightly failures, so it's ready to get comments. |
JohnTitor
reviewed
Jan 18, 2020
|
Just got a mail that says we need to change our azure pipeline config till March 23. (Have to update some runner image versions till then at least.) |
weiznich
force-pushed
the
try/github_actions
branch
from
fe82bb3
to
29cab6d
Compare
If that actually works I'm proposing moving all of our ci/automation
to this service, because of:
* Integration with github seems to be vastly better
+ No need to click n times to go to logs
+ Rerun a failed job is easier
+ Maybe? Inline error messages in PR's
* Error messages are automatically extracted
* I think they have 20 free concurrent jobs, azure has only 10 (so
faster CI)
(Most of the config is copied from wundergraph)
weiznich
force-pushed
the
try/github_actions
branch
from
8a3018a
to
3dfe32c
Compare
JohnTitor
reviewed
May 27, 2020
|
Related things that should be fixed before merging: |
crates.io doesn't display CI-related badge now so we could just remove them. |
* Lower all dependencies to `-Z minimal-versions` in CI
* Raise the following public dependencies:
* bigdecimal to 0.0.13 to drop support for old num versions
* chrono to 0.4.1 because it pulls in a really old num from before
the rust 1.0 release
* pq-sys to 0.4.0 because 0.3.x pulls in a old bindgen version
* mysqlclient-sys to 0.3.0 for the same reason
* Bump this internal dependencies:
* syn to 1.0.1 because we require at least that version
* num-* to 0.2.0 to match bigdecimal version
* bcrypt to 0.2.0 because it would pull in rustc-serialize
otherwise
* tempfile to 3.0.0 because otherwise it pulls in winapi 0.0.1!!!
* bitflags to 1.2.0 because of deprecation warnings regarding to try!
|
@diesel-rs/reviewers Should be ready for a final review |
JohnTitor
approved these changes
May 29, 2020
weiznich
force-pushed
the
try/github_actions
branch
from
eaaee89
to
9d7c587
Compare
weiznich
force-pushed
the
try/github_actions
branch
from
8bd5cb0
to
2bbeb04
Compare
weiznich
force-pushed
the
try/github_actions
branch
from
97844bc
to
22aa391
Compare
JohnTitor
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If that actually works I'm proposing moving all of our ci/automation
to this service, because of:
faster CI)
(Most of the config is copied from wundergraph)