Add supported databases to the readme. #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
reviewed
Feb 16, 2020
Added links to docs for each backend Changed the urls from http to https marked the code block as toml suggested by @JohnTitor Co-Authored-By: Yuki Okushi <huyuumi.dev@gmail.com>
SarthakSingh31
force-pushed
the
task/add_db_to_readme
branch
from
db54cf4
to
144c63f
Compare
JohnTitor
reviewed
Feb 16, 2020
Comment on lines
+22
to
+24
| 1. [PostgreSQL](https://docs.diesel.rs/diesel/pg/index.html) | ||
| 2. [MySQL](https://docs.diesel.rs/diesel/mysql/index.html) | ||
| 3. [SQLite](https://docs.diesel.rs/diesel/sqlite/index.html) |
There was a problem hiding this comment.
Currently, it points to master branch's doc, not released one. I would prefer later but it's not a strong opinion, would like to up to other reviewers.
There was a problem hiding this comment.
We point at various places to the docs for the master branch. With merging #2269 I would suggest moving the docs from the master branch to a different location and having the docs for the latest release there, because there are quite a lot places linking there.
There was a problem hiding this comment.
So should I leave it as it is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294