update/nightly-2020-02-27 #2314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martell
force-pushed
the
update/nightly-2020-02-27
branch
2 times, most recently
from
279c169
to
dc3dc23
Compare
|
hmm, what is interesting is that is passes when it contains #2248 |
|
#2248 will be merged as soon as we get at least another review on that PR, especially on the documentation. |
If that actually works I'm proposing moving all of our ci/automation
to this service, because of:
* Integration with github seems to be vastly better
+ No need to click n times to go to logs
+ Rerun a failed job is easier
+ Maybe? Inline error messages in PR's
* Error messages are automatically extracted
* I think they have 20 free concurrent jobs, azure has only 10 (so
faster CI)
(Most of the config is copied from wundergraph)
martell
force-pushed
the
update/nightly-2020-02-27
branch
from
dc3dc23
to
80d1d53
Compare
martell
force-pushed
the
update/nightly-2020-02-27
branch
from
ee2fd1e
to
f53d49f
Compare
martell
force-pushed
the
update/nightly-2020-02-27
branch
from
f826114
to
de099f9
Compare
|
super-seeded by #2339 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some of the other PRs coming in like #2248 #2257 I have been trying to maintain a fork with both of them in the same branch to see what the world would be like.
In order to simplify some things I thought it would be a good time to upstream the update to
nightly-2020-02-27This currently depends on #2269 ( dc3dc23 is the only real commit here )
I'm not sure what the process for picking a nightly is but I hope this is reasonable.