Feat/dataset slug name map #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
6 tasks
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
commented
Aug 1, 2024
Comment on lines
+3
to
+10
| const getFullServiceName = (service) => { | ||
| if (!service || typeof service !== 'string') { | ||
| throw new Error('Service name must be a non-empty string') | ||
| } | ||
| return config.serviceName.replace('Provide', service) | ||
| } | ||
|
|
||
| export default getFullServiceName |
There was a problem hiding this comment.
this is so we can correctly name each of the sub services.
i.e.
provide planning and housing data
submit planning and housing data
manage ...
etc
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
rosado
reviewed
Aug 1, 2024
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
rosado
reviewed
Aug 1, 2024
GeorgeGoodall
temporarily deployed
to
development
GitHub Actions
Inactive
rosado
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://trello.com/c/cVSkfnNx/3370-get-org-mappings-from-datasette?filter=member:georgegoodall8