-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bevy 0.10 #324
Update to Bevy 0.10 #324
Conversation
Bevy 0.10 will now use glam 0.23. Should probably upgrade here too. Related #331 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -72,20 +72,23 @@ pub fn setup_physics(mut commands: Commands) { | |||
|
|||
fn cast_ray( | |||
mut commands: Commands, | |||
windows: Res<Windows>, | |||
windows: Query<&Window>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should you add With<PrimaryWindow>
filter here to keep the previous behavior? I see you were calling get_primary()
to get the window.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I merged right before seeing your comment. I think this is a good point. I’ll make the change with the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example already didn't support multiple windows so it's effectively the same.
I just followed what Bevy's examples do, but I'll leave it up to seb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries! I'm anxious for this new release tbh. 😆
Thanks everyone!
DetectDespawn
was removed. It existed to make sure that removed components were not missed. This should no longer be an issue asRemovedComponents
is now backed by anEvents<T>
which keeps the events around for an extra frame.Supercedes #331
Tasks
custom_system_setup3
physics_scale
setting (Opened issue Higherphysics_scale
setting causes rigidbodies to sleep when they shouldn't #338). I've removed it from the example since it's 3Dasync_scene_collider_initializes
test that fails/succeeds randomly