Add super-reactions to gateway events #6375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JJRcop
changed the title
2 tasks
TTtie
added a commit
to projectdysnomia/dysnomia
that referenced
this pull request
Aug 26, 2023
DonovanDMC
added a commit
to OceanicJS/Oceanic
that referenced
this pull request
Sep 3, 2023
TTtie
added a commit
to projectdysnomia/dysnomia
that referenced
this pull request
Sep 20, 2023
TTtie
added a commit
to projectdysnomia/dysnomia
that referenced
this pull request
Oct 10, 2023
|
I haven't tested this in a while, but can anyone confirm it still works this way? I will do some tests soon to make sure. |
|
also what's the word on getting this merged (or not merged even?) |
colinloretz
approved these changes
May 15, 2024
3 tasks
suneettipirneni
added a commit
to twilight-rs/twilight
that referenced
this pull request
Jul 13, 2024
Refs: - discord/discord-api-docs#6375 - discord/discord-api-docs#6377 This PR renames the old `ReactionType` to `EmojiReactionType` as the concept of a reaction type now exists in the API.
TTtie
added a commit
to projectdysnomia/dysnomia
that referenced
this pull request
Jul 13, 2024
TTtie
added a commit
to projectdysnomia/dysnomia
that referenced
this pull request
Jul 13, 2024
* feat: super reactions Ref: discord/discord-api-docs@b1bed46 Ref: discord/discord-api-docs#6375 * fix ts lint * feat: allow getting reactions by type over REST * refactor: move the reaction object references to a variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds super-reactions related event members missing from #6056
Was originally a PR to #6056 in Mateo-tem#1, but #6056 was just recently merged before the author of #6056 merged my PR.
I have observed these super-reaction related members in the MESSAGE_REACTION_ADD and MESSAGE_REACTION_REMOVE events as demonstrated below:
Add and Remove Screenshots
burst_colorswas left out of MESSAGE_REACTION_REMOVE because my findings show it is always empty even if it was a super-reactionI have also observed similar members in the MESSAGE_REACTION_REMOVE_EMOJI event, but they don't seem to work the same way so they were omitted.
Add and Remove All Emoji Screenshots