-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Universal support for django CMS v3 and v4 #631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since newer versions of easythumbnailer return float instead of int) Add: Tests for django CMS 4
Add: Remove python 3.7 from tests
Fix: Adjust test to become universal
Fix: remove empty function
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 69.93% 76.18% +6.24%
==========================================
Files 16 20 +4
Lines 449 932 +483
Branches 49 124 +75
==========================================
+ Hits 314 710 +396
- Misses 118 196 +78
- Partials 17 26 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
vinitkumar
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my one review comment
vinitkumar
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PR merges django cms v4 compatibility into the current
develop
branch. It's objective is to unite the two current develop branches (develop
andsupport/4.0.x
) into one branch so that the next release of djangocms-text-ckeditor will support versions 3 and 4 of django CMS universally.This PR essentially adds the changes of the
support/4.0.x
branch to thedevelop
branch and adds appropriate case handling for django CMS v3.x and v4.position
parameter to create child plugins for v4 (also supplied though not relevant for v3)Tests pass for Django 2.2, 3.1, 3.2, and 4.0 and django CMS 3.7, 3.7, 3.9., 3.10, 3.11 and 4.0-develop.
utils.py
adds anis_cms_v4
property which isTrue
for django CMS v4+ and false for django CMS v3. It also has a propertycms_placeholder_add_plugin
which contains the unreversed name of the add plugin endpoint (which differs between v3 and v4).As with the current
support/4.0.x
branch tests currently run w/o using djangocms-versioning.