-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pending migration implied by Django 4.0 changes (#634) #635
Conversation
- Added new migration as expected by Django 4.0 - Pinned django-filer>=1.4.0,<2.1 in tests base requirements because it is incompatible with supported Django versions from tox config
This pull request introduces 3 alerts when merging 8c36817 into 3c34d2d - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 74.91% 69.86% -5.06%
==========================================
Files 20 16 -4
Lines 905 448 -457
Branches 128 49 -79
==========================================
- Hits 678 313 -365
+ Misses 199 118 -81
+ Partials 28 17 -11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
On a side note, coverage reporting needs to ignore migration files. |
This pull request introduces 3 alerts when merging 496b4a8 into 3c34d2d - view on LGTM.com new alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
As a remark: Migration tests are fixed in #631 |
I've launched tox on my work and it runned almost well but failed on environments with Django 3.2 because of missing migrations from some dependencies (filer, easy_thumbnails), possibly because of the same bug we are fixing here.
I'm attaching the full tox run output here so you can check yourself without to run it yet:
tox_log_output.txt
Also i'm not totally sure about my migration which have a dependency to the last CMS one, but i saw there is no CMS migration dependency in any of the djangocms-text-ckeditor migrations, maybe you were removing them for a reason, or this is normal, i don't know..
Let me know if you want me to remove it if it is not expected.