Naming: TypeSystem.create_type but add_feature #173
Comments
jcklie
added a commit
that referenced
this issue
Aug 14, 2021
- Add create_feature - Deprecate add_feature
jcklie
added a commit
that referenced
this issue
Aug 14, 2021
- Add create_feature - Deprecate add_feature - Update README
reckart
added a commit
that referenced
this issue
Aug 19, 2021
* main: #172 - Naming: cas.add_annotation(s) (#181) #175 - Set a feature if the feature name is in a variable (#180) #175 - Set a feature if the feature name is in a variable #174 - FSes that are only transitively referenced cannot be serialized (#179) #170 - Handling of the "uima.noNamespace" prefix (#178) No issue #173 - Rename add_feature to create_feature (#177) # Conflicts: # cassis/typesystem.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The naming for creating how typesystem-related entities seems inconsistent. E.g. we have a
create_typebut then aadd_featuremethod. For consistency, the latter should be renamed tocreate_feature.Also, there should be a remark on the
Type.add_feature()method that it should not be used (maybe even prefix it with_and that theTypeSystem.create_feature()method should be used instead.Best deprecate the old names instead of removing.
The text was updated successfully, but these errors were encountered: