Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#170 - Handling of the "uima.noNamespace" prefix #178

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

jcklie
Copy link
Collaborator

@jcklie jcklie commented Aug 14, 2021

  • Move no namespace handling to xmi
  • Add better tests for this

- Move no namespace handling to xmi
- Add better tests for this
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #178 (2b16de6) into main (9140380) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files           9        9           
  Lines        1873     1875    +2     
=======================================
+ Hits         1826     1828    +2     
  Misses         47       47           
Impacted Files Coverage Δ
tests/test_xmi.py 100.00% <ø> (ø)
cassis/typesystem.py 96.43% <100.00%> (-0.08%) ⬇️
cassis/xmi.py 96.47% <100.00%> (+0.06%) ⬆️
tests/fixtures.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9140380...2b16de6. Read the comment docs.

@jcklie jcklie merged commit f5d396c into main Aug 14, 2021
@jcklie jcklie deleted the feature/170-better-no-namespace-handling branch August 14, 2021 16:03
reckart added a commit that referenced this pull request Aug 19, 2021
* main:
  #172 - Naming: cas.add_annotation(s) (#181)
  #175 - Set a feature if the feature name is in a variable (#180)
  #175 - Set a feature if the feature name is in a variable
  #174 - FSes that are only transitively referenced cannot be serialized (#179)
  #170 - Handling of the "uima.noNamespace" prefix (#178)
  No issue
  #173 - Rename add_feature to create_feature (#177)

# Conflicts:
#	cassis/typesystem.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant