Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to prepare for integer default_left #337

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jan 13, 2022

Respond to dmlc/xgboost#7556, which changes the type of default_left field in XGBoost models to integer array (the field used to be a boolean array).

It turns out that we don't need to change the parser at all. This PR simply adds a unit test.

cc @trivialfis

@hcho3 hcho3 changed the title Add a test to prepare for integer default_left Add a test to prepare for integer default_left Jan 13, 2022
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #337 (1835f92) into mainline (09521bc) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #337      +/-   ##
==============================================
+ Coverage       84.86%   84.92%   +0.05%     
  Complexity         42       42              
==============================================
  Files             108      108              
  Lines            8420     8455      +35     
  Branches          470      471       +1     
==============================================
+ Hits             7146     7180      +34     
- Misses           1251     1252       +1     
  Partials           23       23              
Impacted Files Coverage Δ
src/frontend/xgboost/xgboost_json.h 89.81% <100.00%> (+0.39%) ⬆️
tests/cpp/test_frontend.cc 94.02% <100.00%> (+0.60%) ⬆️
src/annotator.cc 91.07% <0.00%> (-1.20%) ⬇️
src/threading_utils/parallel_for.h 100.00% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09521bc...1835f92. Read the comment docs.

@hcho3 hcho3 merged commit c1c65f8 into dmlc:mainline Jan 13, 2022
@hcho3 hcho3 deleted the allow_int_default_left branch January 13, 2022 16:26
@hcho3 hcho3 mentioned this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants