[breaking] Change internal model serialization to UBJSON. #7556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treelite doesn't need to be updated, since it already handles integer arrays for |
|
Ah, the parser is interesting, I should learn more about it. Thanks for sharing. |
hcho3
requested changes
Jan 14, 2022
trivialfis
force-pushed
the
ubjson-model
branch
from
4cfc74a to
d9687ab
Compare
|
@hcho3 Could you please take another look? |
|
Added an extra optimization to avoid the i64 array for split index. Also, fixed the type used in the tree param.(#7565) |
RAMitchell
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks the schema of JSON, the
default_leftfield is changed from boolean to integer so that we can use typed array. XGBoost itself will continue to load the old models, third-party libraries that depend on this schema will have to make changes accordingly. I can help with treelite once the full PR is merged.Extracted from #7545 .