add Dart booster. #1199
Closed
add Dart booster. #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void DoBoost(DMatrix* p_fmat, | ||
| int64_t buffer_offset, | ||
| std::vector<bst_gpair>* in_gpair) override { | ||
| const std::vector<bst_gpair>& gpair = *in_gpair; |
There was a problem hiding this comment.
Is this function different from parent's DoBoost? If only difference is CcommitModel, we can make CommitModel virtual and override that function
|
, I have made a few comments, please let me know when you have new updates, so I can do another round of review. Thanks for the good job! |
|
@marugari Any updates on this? |
|
Sorry, I'll update by Sunday. |
|
no problem, please take your time |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we use the Dart booster,
UpdateOneIter calls
PredictRaw (with dropped trees by DropTrees),
GetGradient,
DoBoost (with scaling dropped trees by NormalizeTrees).