-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OSX build instructions #2784
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2784 +/- ##
============================================
- Coverage 43.16% 43.08% -0.08%
- Complexity 192 200 +8
============================================
Files 150 151 +1
Lines 11368 11519 +151
Branches 1148 1167 +19
============================================
+ Hits 4907 4963 +56
- Misses 6135 6225 +90
- Partials 326 331 +5
Continue to review full report at Codecov.
|
Any chance this get merged? The original instructions are duplicative and quite confusing sometimes. |
doc/build.md
Outdated
@@ -59,20 +59,12 @@ cd xgboost; make -j4 | |||
|
|||
### Building on OSX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you mention that Clang is OK if OMP support is not needed?
@superbobry Done. Also, I'm wondering if we should include an instruction for Lots of people have been facing that problem too: https://github.com/dmlc/xgboost/issues?utf8=%E2%9C%93&q=%22failed%20with%20error%20code%201%22 |
Good idea, please go ahead. |
Done 😄 |
Shall we merge? 😄 |
Thanks @lenguyenthedat! |
* Update xgboost build for OS X * Add notes on gcc and brew * Update build.md * Update build.md * Update build.md
Keeping things simpler for OS X users:
brew install gcc
is now at v 0.7.2,--without-multilib
isn't an option anymore:(it's actually not needed in our case as
there is no incompatibility between OpenMP and multilib support
Homebrew/homebrew-core#16751)