Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback interface to re-direct console output #3438

Merged
merged 3 commits into from
Jul 5, 2018

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jul 4, 2018

Addresses #3020. Any language wrapper can call XGBRegisterLogCallback() to intercept the output of LOG(INFO) and LOG(CONSOLE).

@hcho3 hcho3 closed this Jul 4, 2018
@hcho3 hcho3 reopened this Jul 4, 2018
@codecov-io
Copy link

codecov-io commented Jul 5, 2018

Codecov Report

Merging #3438 into master will increase coverage by 0.04%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3438      +/-   ##
============================================
+ Coverage     45.73%   45.77%   +0.04%     
  Complexity      188      188              
============================================
  Files           166      166              
  Lines         13115    13138      +23     
  Branches        442      442              
============================================
+ Hits           5998     6014      +16     
- Misses         6916     6923       +7     
  Partials        201      201
Impacted Files Coverage Δ Complexity Δ
src/c_api/c_api.cc 23.96% <0%> (-0.17%) 0 <0> (ø)
src/logging.cc 69.23% <100%> (+19.23%) 0 <0> (ø) ⬇️
include/xgboost/logging.h 75% <66.66%> (-8.34%) 0 <0> (ø)
python-package/xgboost/core.py 83.51% <87.5%> (+0.05%) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01aff45...a212bb1. Read the comment docs.

@hcho3 hcho3 merged commit 48d6e68 into dmlc:master Jul 5, 2018
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Jul 26, 2018
* Add callback interface to re-direct console output

* Exempt TrackerLogger from custom logging

* Fix lint
@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
@hcho3 hcho3 deleted the log_callback branch July 24, 2020 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants