Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON model dump functionality documentation #3600

Merged
merged 1 commit into from
Aug 16, 2018
Merged

Add JSON model dump functionality documentation #3600

merged 1 commit into from
Aug 16, 2018

Conversation

grace-lam
Copy link
Contributor

I wrote a native XGBoost to Vespa converter that uses XGBoost's JSON model dump as input (vespa-engine/vespa#6577), so I added some missing documentation for the existing dump_format parameter in the CLI version.

@codecov-io
Copy link

Codecov Report

Merging #3600 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #3600     +/-   ##
===========================================
+ Coverage     49.93%   50.04%   +0.1%     
  Complexity      188      188             
===========================================
  Files           172      172             
  Lines         13877    13877             
  Branches        457      457             
===========================================
+ Hits           6930     6945     +15     
+ Misses         6722     6707     -15     
  Partials        225      225
Impacted Files Coverage Δ Complexity Δ
src/data/sparse_page_raw_format.cc 41.5% <0%> (-22.65%) 0% <0%> (ø)
src/data/sparse_page_dmatrix.cc 92.3% <0%> (-0.6%) 0% <0%> (ø)
python-package/xgboost/compat.py 90.9% <0%> (+1.81%) 0% <0%> (ø) ⬇️
python-package/xgboost/core.py 83.41% <0%> (+4.61%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725f4c3...f99f525. Read the comment docs.

@hcho3 hcho3 merged commit caf4a75 into dmlc:master Aug 16, 2018
@hcho3
Copy link
Collaborator

hcho3 commented Aug 16, 2018

Thanks!

@grace-lam grace-lam deleted the json-dump-documentation branch August 16, 2018 23:59
hcho3 pushed a commit that referenced this pull request Sep 5, 2018
hcho3 pushed a commit that referenced this pull request Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants